Bugfix - Customer emails are not being sent from admin if customer is from store "0"

[matheusgontijo]

Description (*)

Emails are not being sent to customers assigned to store id "0". Actually, store id "0", in the following context should be considered as a valid store id, since it's "admin". The if conditions should be actually checking if the store id is null: if ($storeId === null) { instead of if (!$storeId) {.

Manual testing scenarios (*)

In order to reproduce the issue:

• Create a customer from admin (then customer will have store_id = 0)
• Go to customer edit page on admin and try to click Reset Password
• The email will not get and will throw an error.

[m2-assistant]

Hi @matheusgontijo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[nuzil]

@magento give me 2.4-develop instance

[magento-engcom-team]

Hi @nuzil. Thank you for your request. I'm working on Magento 2.4-develop instance for you

[magento-engcom-team]

Hi @nuzil, here is your Magento instance.
Admin access: https://i-26293-2-4-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[nuzil]

On Vanilla 2.4 Magento I cannot create customer with Admin scope

[matheusgontijo]

Anyways, let consider we created a customer programmatically through an integration, and the customer was assigned to store id 0 to be globally used among several stores. This customer will not receive any email notifications.

[nuzil]

Ok, by the core logic it's possible to have such behaviour.
But I will ask you to change this types:
https://github.com/magento/magento2/pull/26293/files#diff-216320d539f904af6160bad485978341L365

Cause your implementation is assume that storeId can be also null.

[matheusgontijo]

there we go @nuzil — modification done!

Could we merge now? Thank you!

[nuzil]

Hi @matheusgontijo can you please cover with tests your changes?

[engcom-Echo]

I will take care of test coverage.

[nuzil]

@magento run all tests

[nuzil]

@engcom-Echo can you please merge 2.4 one more time?

[engcom-Echo]

@magento run all tests

[magento-engcom-team]

Hi @nuzil, thank you for the review.
ENGCOM-7445 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Programmatically create a new customer (test user for ex.) (will have store_id = 0)
   ;

2. Go to Admin -> Customers -> All Customers;

3. Click on edit link for created before customer;

4. Click on Reset Password button;

Before:
✖️ an error has been occured

After:
✔️ The password reset email was sent

[m2-assistant]

Hi @matheusgontijo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.