Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CurrencySymbol] Fixing the redirect after saving the currency symbols #26311

Merged

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Jan 8, 2020

Description (*)

This PR fixes the redirect path after saving the currency rates.

Fixed Issues (if relevant)

  1. Navigate to Stores / Currency Symbols
  2. Save symbols
  3. You're redirected to Dashboard with the Success message ❌

Manual testing scenarios (*)

  1. Navigate to Stores / Currency Symbols
  2. Save symbols
  3. You should stay on the same submitted page ✅

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@eduard13 eduard13 requested a review from akaplya as a code owner January 8, 2020 13:01
@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2020

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 8, 2020
@rogyar rogyar self-assigned this Jan 8, 2020
@rogyar
Copy link
Contributor

rogyar commented Jan 8, 2020

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-26311.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 8, 2020
@rogyar
Copy link
Contributor

rogyar commented Jan 8, 2020

Hi @eduard13. Thank you for the fix. Good catch!

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6563 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Echo
Copy link
Contributor

@magento run all tests

@magento-engcom-team magento-engcom-team merged commit f7d8602 into magento:2.4-develop Jan 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 17, 2020

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: CurrencySymbol Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants