#26314: fixed logic for updating map price for selected swatch

[sergiy-v]

Description

Fixed logic for updating map price for selected swatch option on product list

Fixed Issues

1. Minimum Advertised Prices duplicates for all configurable products with price from selected swatch #26314

Manual testing scenarios

1. Enable MAP (Stores -> Configuration -> Sales -> Sales -> Minimum Advertised Price -> Enable MAP).
2. Enable 'Show Swatches in Product List', enabled by default (Stores -> Configuration -> Catalog -> Catalog -> Storefront -> Show Swatches in Product List).
3. The product attribute uses for configurable products should be visible on Product List (Stores -> Attributes -> Product -> select attribute -> Storefront Properties -> Used in Product Listing) in order to show attribute swatches for Product List.
4. Create few configurable products for the attribute with 'swatch' (Visual Swatch, Text Swatch) type with associated products:
   • Configurable A:
     • Black A: price 1, MAP 11. (ex: 'black' color)
     • White A: price 2, MAP 12. (ex: 'white' color)
   • Configurable B:
     • Black B: price 10, MAP 110. (ex: 'black' color)
     • White B: price 20, MAP 120. (ex: 'white' color)
5. Create category, assign created products.
   

Questions or comments

Better to test once the changes from the #26240 will be merged.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[dmytro-ch]

Hello @sergiy-v, could you please check the failing unit test tests/js/jasmine/tests/app/code/Magento/Msrp/frontend/js/msrp.test.js?
Thank you! :)

[sergiy-v]

Hello @sergiy-v, could you please check the failing unit test tests/js/jasmine/tests/app/code/Magento/Msrp/frontend/js/msrp.test.js?
Thank you! :)

Hello @dmytro-ch, I'll check it, thank you!

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-6685 has been created to process this Pull Request

[engcom-Alfa]

Hi @sergiy-v,

During testing, we faced the issue

Problem: The minimum advertised price does not change after the swatches have been selected

Manual testing scenario:

1. Enable MAP (Stores -> Configuration -> Sales -> Sales -> Minimum Advertised Price -> Enable MAP).
2. Enable 'Show Swatches in Product List', enabled by default (Stores -> Configuration -> Catalog -> Catalog -> Storefront -> Show Swatches in Product List).
3. The product attribute uses for configurable products should be visible on Product List (Stores -> Attributes -> Product -> select attribute -> Storefront Properties -> Used in Product Listing) in order to show attribute swatches for Product List.
4. Create few configurable products for the attribute with 'swatch' (Visual Swatch, Text Swatch) type with associated products and assign created products to category :
   Configurable A:
   Black A: price 1, MAP 11. (ex: 'black' color)
   White A: price 2, MAP 12. (ex: 'white' color)
   Configurable B:
   Black B: price 10, MAP 110. (ex: 'black' color)
   White B: price 20, MAP 120. (ex: 'white' color)

Actual Result:
When we switch between swatches, MAP should change too

@sergiy-v Could you take a look?

Thanks!

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-6685 has been created to process this Pull Request

[engcom-Alfa]

Hi @sergiy-v.
The issue described in my comment can still be reproduced with PR changes

Actual Result:

And the problem #26240 that has been resolved in #26241 is returned

Actual Result:

@sergiy-v Could you take a look?

Thanks!

[sergiy-v]

@magento give me test instance

[magento-engcom-team]

Hi @sergiy-v. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @sergiy-v, here is your new Magento instance.
Admin access: https://pr-26317.instances.magento-community.engineering/admin_ad24
Login: ea183482 Password: b85c18f4d7d2
Instance will be terminated in up to 3 hours.

[sergiy-v]

Hi @sergiy-v.
The issue described in my comment can still be reproduced with PR changes

Actual Result:

And the problem #26240 that has been resolved in #26241 is returned

Actual Result:

@sergiy-v Could you take a look?

Thanks!

Hello @engcom-Alfa,
The changes works fine on my the local environment and created test environment (see credentials above). You can check the result on the test environment. Maybe I missed something.
Could you please check it one more time?

Thank you.

[engcom-Alfa]

✔️ QA Passed

Actual Result:

[m2-assistant]

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.