Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFTF: Set of fixes for failing Functional Tests #26407

Merged

Conversation

lbajsarowicz
Copy link
Contributor

Description (*)

Functional Tests are running simultaneously and as a result - sometimes the Magento instances created for Testing are just overloaded. As mentioned in #26396 - that's because we get False Negatives.

Fixed Issues (if relevant)

  1. MFTF: Functional Tests are failing in Magento CI process #26396 DeleteProduct and DeleteCustomer Action Groups failure

Manual testing scenarios (*)

  1. Add . to README in random place
  2. Create Pull Request

Questions or comments

🤦‍♂️

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 15, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Mediotype partners-contribution Pull Request is created by Magento Partner labels Jan 15, 2020
@okorshenko
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko. Thank you for your request. I'm working on Magento instance for you

@okorshenko
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko, here is your new Magento instance.
Admin access: https://pr-26407.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Jan 16, 2020
@ihor-sviziev
Copy link
Contributor

Here is some issue with unit tests, but I't definitely not related to this PR.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6621 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Jan 16, 2020
@Nazar65 Nazar65 self-assigned this Jan 16, 2020
@ghost ghost unassigned Nazar65 Jan 16, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

@Nazar65 unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@engcom-Golf engcom-Golf self-assigned this Jan 16, 2020
@lenaorobei lenaorobei added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jan 16, 2020
@magento-engcom-team magento-engcom-team merged commit 8b40fac into magento:2.4-develop Jan 25, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 25, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants