Add frontend template hints status command #26451

WaPoNe · 2020-01-18T11:38:32Z

Description (*)

Add frontend template hints status command

Fixed Issues (if relevant)

This is a simple command to show the frontend template hints status in adding to dev:template-hints:enable and dev:template-hints:disable commands.

magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-01-18T11:38:34Z

Hi @WaPoNe. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

lbajsarowicz

Please find comments to PR.

app/code/Magento/Developer/Console/Command/TemplateHintsShowCommand.php

app/code/Magento/Developer/Console/Command/TemplateHintsStatusCommand.php

lbajsarowicz · 2020-01-20T18:29:54Z

Still static tests to be fixed:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/26451/d8a4b608254ee25ff7419a2c753532d2/Statics/allure-report-b2b/index.html#suites/51d3ab4d5d77a0bc6a7ea344e9e7e6be/3ebfc3b39b7c0507/

WaPoNe · 2020-01-21T16:52:35Z

The checks are failing for some reasons that not depend by my files.
@lbajsarowicz could you check, please?

lbajsarowicz

Comments are not necessary to const :-)

app/code/Magento/Developer/Console/Command/TemplateHintsStatusCommand.php

WaPoNe · 2020-01-23T08:38:04Z

@lbajsarowicz any news?

lbajsarowicz

Good job! Only the last changes to be performed and we'll be done.

app/code/Magento/Developer/Console/Command/TemplateHintsStatusCommand.php

lbajsarowicz

Cosmetics :-)

app/code/Magento/Developer/Console/Command/TemplateHintsStatusCommand.php

lbajsarowicz

OK. Let's wait for all tests pass.
PR approved.

Parenthesis for return() is not necessary, but generally it's ok.

magento-engcom-team · 2020-01-23T10:23:37Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6668 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

magento-engcom-team · 2020-01-23T10:23:39Z

@WaPoNe thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

app/code/Magento/Developer/Test/Unit/Console/Command/TemplateHintsStatusCommandTest.php

lbajsarowicz

I see some regression, but we are really close!

app/code/Magento/Developer/Test/Unit/Console/Command/TemplateHintsStatusCommandTest.php

lbajsarowicz · 2020-01-29T16:17:39Z

app/code/Magento/Developer/Console/Command/TemplateHintsStatusCommand.php

+    {
+        $this->reinitableConfig->reinit();
+        $templateHintsStatus =
+            $this->scopeConfig->isSetFlag(self::TEMPLATE_HINTS_STOREFRONT_PATH, 'default')


Wasn't that line extracted to private method?

You're right @lbajsarowicz but I was able to test that private method that gave me strange errors.

@lbajsarowicz I brought it back and changed unit tests to verify single interfaces.

app/code/Magento/Developer/Console/Command/TemplateHintsStatusCommand.php

lbajsarowicz · 2020-01-29T16:39:01Z

You should not test private methods, but output of the interface, as unit tests are to test single interfaces, not single methods.

lbajsarowicz

OK.

magento-engcom-team · 2020-02-01T10:53:38Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6668 has been created to process this Pull Request

engcom-Alfa · 2020-02-03T08:57:15Z

✔️ QA Passed

engcom-Echo · 2020-02-03T08:58:32Z

@magento run all tests

… 2.4-develop_WaPoNe

m2-assistant · 2020-02-09T00:23:10Z

Hi @WaPoNe, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Add frontend template hints status command

a39bc8c

WaPoNe requested a review from buskamuza as a code owner January 18, 2020 11:38

lbajsarowicz suggested changes Jan 18, 2020

View reviewed changes

ghost assigned lbajsarowicz Jan 18, 2020

ghost added the Progress: needs update label Jan 18, 2020

Add frontend template hints status command after suggestions

f4a46e7

WaPoNe requested a review from lbajsarowicz January 20, 2020 09:04

lbajsarowicz suggested changes Jan 20, 2020

View reviewed changes

app/code/Magento/Developer/Console/Command/TemplateHintsStatusCommand.php Outdated Show resolved Hide resolved

app/code/Magento/Developer/Console/Command/TemplateHintsStatusCommand.php Outdated Show resolved Hide resolved

Add frontend template hints status command after suggestions

a4aa69b

WaPoNe requested a review from lbajsarowicz January 20, 2020 10:42

Michele Fantetti added 2 commits January 21, 2020 09:16

Add frontend template hints status command after suggestions

bdb4679

Add frontend template hints status command after suggestions

a8041a1

lbajsarowicz suggested changes Jan 21, 2020

View reviewed changes

Add frontend template hints status command after suggestions

c4c5d73

WaPoNe requested a review from lbajsarowicz January 21, 2020 21:29

lbajsarowicz suggested changes Jan 23, 2020

View reviewed changes

Add frontend template hints status command after suggestions

8e6b0c8

lbajsarowicz suggested changes Jan 23, 2020

View reviewed changes

app/code/Magento/Developer/Console/Command/TemplateHintsStatusCommand.php Outdated Show resolved Hide resolved

app/code/Magento/Developer/Console/Command/TemplateHintsStatusCommand.php Outdated Show resolved Hide resolved

Add frontend template hints status command after suggestions

d4cbfaf

lbajsarowicz approved these changes Jan 23, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Jan 23, 2020

magento-engcom-team added Release Line: 2.4 Component: Developer labels Jan 23, 2020

engcom-Echo reviewed Jan 27, 2020

View reviewed changes

Michele Fantetti and others added 2 commits January 27, 2020 17:16

Add frontend template hints status command unit tests after suggestions

83e6070

Minor changes

6f14ca2

engcom-Echo added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jan 28, 2020

Add frontend template hints status command after suggestions

ac66ee7

engcom-Echo requested a review from lbajsarowicz January 29, 2020 15:26

lbajsarowicz suggested changes Jan 29, 2020

View reviewed changes

Add frontend template hints status command unit tests after suggestions

a7504d7

Add frontend template hints status command unit tests after suggestions

324ee91

WaPoNe requested a review from lbajsarowicz February 1, 2020 10:48

lbajsarowicz approved these changes Feb 1, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Feb 1, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Feb 3, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Feb 3, 2020

engcom-Echo added 2 commits February 3, 2020 12:06

Merge branch '2.4-develop' of http://github.com/magento/magento2 into…

12b7a35

… 2.4-develop_WaPoNe

Minor change

9c0a76f

ghost added Progress: accept and removed Progress: extended testing labels Feb 3, 2020

magento-engcom-team added the Award: test coverage label Feb 6, 2020

magento-engcom-team pushed a commit that referenced this pull request Feb 9, 2020

ENGCOM-6668: Add frontend template hints status command #26451

97bd34c

magento-engcom-team merged commit 9c0a76f into magento:2.4-develop Feb 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add frontend template hints status command #26451

Add frontend template hints status command #26451

WaPoNe commented Jan 18, 2020

m2-assistant bot commented Jan 18, 2020

lbajsarowicz left a comment

lbajsarowicz commented Jan 20, 2020

WaPoNe commented Jan 21, 2020

lbajsarowicz left a comment

WaPoNe commented Jan 23, 2020

lbajsarowicz left a comment

lbajsarowicz left a comment

lbajsarowicz left a comment

magento-engcom-team commented Jan 23, 2020

magento-engcom-team commented Jan 23, 2020

lbajsarowicz left a comment

lbajsarowicz Jan 29, 2020

WaPoNe Jan 29, 2020

WaPoNe Feb 1, 2020

lbajsarowicz commented Jan 29, 2020

lbajsarowicz left a comment

magento-engcom-team commented Feb 1, 2020

engcom-Alfa commented Feb 3, 2020

engcom-Echo commented Feb 3, 2020

m2-assistant bot commented Feb 9, 2020

Add frontend template hints status command #26451

Add frontend template hints status command #26451

Conversation

WaPoNe commented Jan 18, 2020

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Jan 18, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

lbajsarowicz commented Jan 20, 2020

WaPoNe commented Jan 21, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

WaPoNe commented Jan 23, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

lbajsarowicz left a comment

Choose a reason for hiding this comment

lbajsarowicz left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Jan 23, 2020

magento-engcom-team commented Jan 23, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

lbajsarowicz Jan 29, 2020

Choose a reason for hiding this comment

WaPoNe Jan 29, 2020

Choose a reason for hiding this comment

WaPoNe Feb 1, 2020

Choose a reason for hiding this comment

lbajsarowicz commented Jan 29, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Feb 1, 2020

engcom-Alfa commented Feb 3, 2020

engcom-Echo commented Feb 3, 2020

m2-assistant bot commented Feb 9, 2020