magento/magento2#: GraphQl. RevokeCustomerToken. Test coverage.

[atwixfirster]

Description (*)

Pull request adds a unit test for \Magento\CustomerGraphQl\Model\Resolver\RevokeCustomerToken class.

Fixed Issues (if relevant)

1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Thank you!

[m2-assistant]

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[engcom-Delta]

Notice: QA not applicable

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-6637 has been created to process this Pull Request

[lenaorobei]

This mutation is already covered by \Magento\GraphQl\Customer\RevokeCustomerTokenTest. If some cases are not covered please consider adding it to the api-functional test.
Thanks.

[atwixfirster]

This mutation is already covered by \Magento\GraphQl\Customer\RevokeCustomerTokenTest

@lenaorobei , could you please clarify. For which GraphQl modules unit tests are applicable?

Thank you!

[dmytro-ch]

@atwixfirster I guess, @lenaorobei meant that the unit tests are useless for GraphQl in general. It's better to add an API-functional test if you wish to cover some logic. :)
Thank you!

[atwixfirster]

@atwixfirster I guess, @lenaorobei meant that the unit tests are useless for GraphQl in general. It's better to add an API-functional test if you wish to cover some logic. :)
Thank you!

Thank you, @dmytro-ch , for the explanation.

However, I would like to know an official Magento position about Unit Tests. Because some GraphQl modules already covered by Unit and API-functional tests.

For example, Magento\WishlistGraphQl\Model\Resolver\CustomerWishlistResolver covered by

• Magento\WishlistGraphQl\Test\Unit\CustomerWishlistResolverTest(Unit Test)
• Magento\GraphQl\Wishlist\WishlistTest (API-functional test)

So, I want to understand why Unit tests are good for some GraphQl classes and what is the difference between \Magento\WishlistGraphQl\Test\Unit\CustomerWishlistResolverTest and my one - \Magento\CustomerGraphQl\Model\Resolver\RevokeCustomerToken.

Also good to know for which GraphQl classes we can create Unit Tests.

@lenaorobei , could you please clarify?

Thank you so much!

[lenaorobei]

Hi @atwixfirster,

Yes, @dmytro-ch is correct about the value of unit tests. They make sense only in the development phase.

I left the same comment in PRs with unit tests you've mentioned #26125 (comment) and asked @lbajsarowicz to not contribute more in this.

Also good to know for which GraphQl classes we can create Unit Tests.

There are no such classes. Positive and negative scenarios for queries and mutations should be covered with API functional tests. For more information please refer to the Magento definition of done.

[atwixfirster]

Understood

Thank you very much, @lenaorobei !

[m2-assistant]

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.