-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed grid multiselect issue #24400 #26488
Conversation
Hi @maheshWebkul721. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento run Static Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @maheshWebkul721 . Thank you for your contribution.
Please fix the static tests.
Currently, build error is not available, however, I have the problem description:
Stacktrace
disallowTrailingWhitespace: Illegal trailing whitespace at app/code/Magento/Ui/view/base/web/js/grid/columns/multiselect.js :
238 | var total = this.getIds().length,
239 | selected = this.getPageSelections().length;
240 |
--------^
241 | if (this.isPageSelected() && selected !== total) {
242 | return this.selectPage();
Guys, thank you for the identification of the issue. We are working on fixing that. |
Full issue log:
|
hey @maheshWebkul721 @novikor We have fixed the issue with static tests https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/26488/a80d343adf054ec702e7edda682c8229/Statics/allure-report-b2b/index.html#suites/3a29d43e5c1686787ff8c2a77e590abb/678be20ee8bc32a5/ |
Hi |
Hi @novikor, thank you for the review.
|
Hi, @maheshWebkul721 |
Hi @sidolov, thank you for the review. |
@magento give me test instance |
Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you |
Hi @engcom-Alfa, here is your new Magento instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @maheshWebkul721 .
During testing, we faced the issue.
Manual testing scenario:
-
Login to the backend;
-
In the 'Search by keyword' box, enter 'first' and search;
-
In the first column, choose the 'Select All' option;
-
Notice that one record is selected:
- Remove the 'first' keyword search by pressing the 'x' icon to the right of it.
- Notice that it now says that one record is selected,
✖️ but visually all records have a checkmark:
Actual Result: ✖️ All products have been removed instead of 1.
@maheshWebkul721 Could you take a look?
Thanks!
Pull Request state was updated. Re-review required.
@magento run all tests |
@magento run all test |
@magento run all tests |
Hi @maheshWebkul721, thanks for your contribution. After looking at the issue and the possible solutions we've decided to proceed with this PR #29968 that aims to fix the same issue. The approach that was chosen was to preserve the same behavior that we have with filters. So when a search tag is removed from filters the previous selection becomes invalid and it is dismissed. As result, we have the same behavior across multiple functionalities on the grid. I will be closing this PR but feel free to reopen it anytime. |
Hi @maheshWebkul721, thank you for your contribution! |
Grid Multi-Select Column Issue Fixed in this PR
Description (*)
Fixed issues related to multi-select column.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)