#26499 Always transliterate product url key

[DanieliMi]

Description (*)

\Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator::prepareProductUrlKey will always call \Magento\Catalog\Model\Product::formatUrlKey in order to transliterate it and avoid spaces, non latin characters, etc. in url_key.

Fixed Issues (if relevant)

1. Fixes Product url key is not transliterated anymore if already set #26499 : Product url key is not transliterated anymore if already set

Manual testing scenarios (*)

1. Edit a product and add "test url key" as url key
2. Save the product
3. Now the url key will be "test-url-key" as it behaved prior to 2.3.3 and 2.2.9

This can be reproduced via rest API too by updating a product url key.

Questions or comments

It might conflict with the issue that has been fixed in 6f4f511. If the tests fail we'll have to think of a different solution.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @DanieliMi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

@magento run all tests

[rogyar]

Hi @DanieliMi.

Thank you for your collaboration. I would ask you to take a look at the failing functional tests. According to the screenshot, it looks like the system tries to open a testable product using the wrong URL after changes introduced in the current PR.

[DanieliMi]

Exactly it tries to visit the product page based on the product name with spaces in it. This PR aims to replace the spaces with '_'. I'll have to update the according tests.

[engcom-Echo]

@magento run all tests

[DanieliMi]

@rogyar I've had a look at the functional tests and fixed them. Currently static tests and database tests are failing.

The static tests fail due to a missing class description, I am not sure what it best could be since I only changed a line in the class do you have any ideas?

I am not sure how the database compare tests work and how to fix them could you assist me with them?

[engcom-Echo]

I will try fix it.

[engcom-Echo]

@magento run all tests

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7064 has been created to process this Pull Request

[magento-engcom-team]

@DanieliMi thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @DanieliMi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.