Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/26526 Fix orderRepository does not check if there are no extens… #26527

Merged
merged 4 commits into from
Sep 14, 2020

Conversation

PascalBrouwers
Copy link
Contributor

@PascalBrouwers PascalBrouwers commented Jan 24, 2020

…ionAttributes

Description (*)

Fixed Issues (if relevant)

  1. Fixes orderRepository does not check if there are no extensionAttributes #26526: orderRepository does not check if there are no extensionAttributes

Manual testing scenarios (*)

  1. Have an order which has no extensionAttributes
  2. Try to load the order using orderRepository

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 24, 2020

Hi @PascalBrouwers. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: H&O partners-contribution Pull Request is created by Magento Partner labels Jan 24, 2020
@rodrigowebjump rodrigowebjump self-assigned this Jan 24, 2020
@magento-engcom-team magento-engcom-team added this to Review in Progress in Pull Requests Dashboard Mar 24, 2020
@sidolov sidolov added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Aug 17, 2020
Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PascalBrouwers nice catch! Could you please cover the changes with any type of automated tests?

@ghost ghost moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Aug 19, 2020
@ghost ghost assigned sidolov Aug 19, 2020
@engcom-Charlie
Copy link
Contributor

Hi @PascalBrouwers can you please look at #26526 (comment)?
Thank you.

@engcom-Foxtrot engcom-Foxtrot self-assigned this Sep 4, 2020
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Sep 4, 2020
@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Reach Digital Pull Request is created by partner Reach Digital Component: Sales labels Sep 4, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8134 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

… method when address method is null - static test fix.
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Alfa engcom-Alfa self-assigned this Sep 14, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 14, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 14, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Have an order which has no extensionAttributes
  2. Try to load the order using orderRepository

Before: ✖️ Error: Call to a member function setAppliedTaxes() on null in the system.log file

Screenshot from 2020-09-14 10-07-52

After: ✔️ The order is successfully loaded

Screenshot from 2020-09-14 11-18-35

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 14, 2020
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 14, 2020
@engcom-Alfa engcom-Alfa moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Sep 14, 2020
@magento-engcom-team magento-engcom-team merged commit 0f51330 into magento:2.4-develop Sep 14, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2020

Hi @PascalBrouwers, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Sales Partner: H&O Partner: Reach Digital Pull Request is created by partner Reach Digital partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

orderRepository does not check if there are no extensionAttributes
7 participants