Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Csp] Covering the model classes by Unit Tests #26558

Merged
merged 4 commits into from
Feb 7, 2020
Merged

[Csp] Covering the model classes by Unit Tests #26558

merged 4 commits into from
Feb 7, 2020

Conversation

eduard13
Copy link
Contributor

Description (*)

This PR covers the following model classes by Unit Tests:

  • Magento\Csp\Model\PolicyRendererPool
  • Magento\Csp\Model\Mode\ConfigManager

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 28, 2020

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 28, 2020
@dmytro-ch dmytro-ch self-assigned this Jan 28, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6725 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

lbajsarowicz
lbajsarowicz suggested changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotations are discouraged in PHPUnit and finally in version 9 are removed.

app/code/Magento/Csp/Test/Unit/Model/Mode/ConfigManagerTest.php Outdated
use RuntimeException;

/**
* Class ConfigManagerTest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This annotation is not necessary.

app/code/Magento/Csp/Test/Unit/Model/Mode/ConfigManagerTest.php Outdated
Comment on lines 75 to 76
* @expectedExceptionMessage CSP can only be configured for storefront or admin area
* @expectedException RuntimeException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use $this->expectException and $this->expectExceptionMessage instead.
Annotations are going to be deprecated in further versions of PHPUnit and finally removed in PHPUnit 9.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lbajsarowicz, that's makes sense.
Thanks.

app/code/Magento/Csp/Test/Unit/Model/PolicyRendererPoolTest.php
*/
class PolicyRendererPoolTest extends TestCase
{
private const STUB_POLICY_ID = 'header';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghost ghost assigned lbajsarowicz Jan 28, 2020
lbajsarowicz
lbajsarowicz approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6725 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Jan 29, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 29, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Jan 29, 2020
@ghost ghost added the Progress: accept label Jan 29, 2020
magento-engcom-team pushed a commit that referenced this pull request Feb 7, 2020
@slavvka
ENGCOM-6725: [Csp] Covering the model classes by Unit Tests #26558
967e424
@magento-engcom-team magento-engcom-team merged commit 270e8e4 into magento:2.4-develop Feb 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Csp Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@eduard13 @magento-engcom-team @engcom-Alfa @lbajsarowicz @dmytro-ch @engcom-Charlie