Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Search Term Entity Redirect Works on Store Front by MFTF Test #26574

Merged

Conversation

DmitryTsymbal
Copy link
Contributor

Description

Verify if Search Term Entity with Redirect Works Correctly on StoreFront

Fixed Issues (if relevant)

Manual testing scenarios (*)

Covered by MFTF
Steps:
1 - Login As Admin User
2 - Navigate To Marketing Search Terms Grid
3 - Create Custom Search Term With Redirect
4 - Navigate To StoreFront
5 - Fill in Search Field, Submit Search Request
6 - Assert Current Url

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 29, 2020

Hi @DmitryTsymbal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 29, 2020
@dmytro-ch dmytro-ch self-assigned this Jan 29, 2020
@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage labels Jan 29, 2020
@NataFurlet
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @NataFurlet. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @NataFurlet, here is your Magento instance.
Admin access: https://i-26574-2-4-develop.instances.magento-community.engineering/admin_7a05
Login: 5d2ee8b6 Password: ebace5046922
Instance will be terminated in up to 3 hours.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6765 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

QA not applicable

@ghost ghost added the Progress: accept label Jan 30, 2020
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, actually!
Thanks for your contribution.

Just minor reusability hint to be introduced, but not crucial for now.

Comment on lines +34 to +38
<amOnPage url="{{AdminCatalogSearchTermIndexPage.url}}" stepKey="navigateToSearchTermPage"/>
<actionGroup ref="AdminSearchTermFilterBySearchQueryActionGroup" stepKey="findCreatedTerm">
<argument name="searchQuery" value="{{SearchTerm.query_text}}"/>
</actionGroup>
<actionGroup ref="AdminDeleteSearchTermActionGroup" stepKey="deleteCreatedSearchTerm"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create AdminDeleteSearchTermByQueryActionGroup that actually extends AdminSearchTermFilterBySearchQueryActionGroup and adds <amOnPage url="{{AdminCatalogSearchTermIndexPage.url}}" stepKey="navigateToSearchTermPage"/> before first step and <actionGroup ref="AdminDeleteSearchTermActionGroup" stepKey="deleteCreatedSearchTerm"/> after last step? :-)

I'm pretty sure that other tests related with SearchTerms will benefit from that change.

@ghost ghost assigned lbajsarowicz Jan 30, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6765 has been created to process this Pull Request

<annotations>
<stories value="Search Term Redirect"/>
<title value="Create Search Term Entity With Redirect. Check How Redirect is Working on Storefront"/>
<description value="Storefront search by created search term with redirect. Verifying if created redirect is working"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <severity> annotation is missing here.

@magento-engcom-team magento-engcom-team merged commit 684ae8e into magento:2.4-develop Feb 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2020

Hi @DmitryTsymbal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Search Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants