-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover Search Term Entity Redirect Works on Store Front by MFTF Test #26574
Cover Search Term Entity Redirect Works on Store Front by MFTF Test #26574
Conversation
Hi @DmitryTsymbal. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me 2.4-develop instance |
Hi @NataFurlet. Thank you for your request. I'm working on Magento 2.4-develop instance for you |
Hi @NataFurlet, here is your Magento instance. |
Hi @dmytro-ch, thank you for the review. |
QA not applicable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, actually!
Thanks for your contribution.
Just minor reusability hint to be introduced, but not crucial for now.
<amOnPage url="{{AdminCatalogSearchTermIndexPage.url}}" stepKey="navigateToSearchTermPage"/> | ||
<actionGroup ref="AdminSearchTermFilterBySearchQueryActionGroup" stepKey="findCreatedTerm"> | ||
<argument name="searchQuery" value="{{SearchTerm.query_text}}"/> | ||
</actionGroup> | ||
<actionGroup ref="AdminDeleteSearchTermActionGroup" stepKey="deleteCreatedSearchTerm"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create AdminDeleteSearchTermByQueryActionGroup
that actually extends AdminSearchTermFilterBySearchQueryActionGroup
and adds <amOnPage url="{{AdminCatalogSearchTermIndexPage.url}}" stepKey="navigateToSearchTermPage"/>
before first step and <actionGroup ref="AdminDeleteSearchTermActionGroup" stepKey="deleteCreatedSearchTerm"/>
after last step? :-)
I'm pretty sure that other tests related with SearchTerms will benefit from that change.
Hi @lbajsarowicz, thank you for the review. |
<annotations> | ||
<stories value="Search Term Redirect"/> | ||
<title value="Create Search Term Entity With Redirect. Check How Redirect is Working on Storefront"/> | ||
<description value="Storefront search by created search term with redirect. Verifying if created redirect is working"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The <severity>
annotation is missing here.
Hi @DmitryTsymbal, thank you for your contribution! |
Description
Verify if Search Term Entity with Redirect Works Correctly on StoreFront
Fixed Issues (if relevant)
Manual testing scenarios (*)
Covered by MFTF
Steps:
1 - Login As Admin User
2 - Navigate To Marketing Search Terms Grid
3 - Create Custom Search Term With Redirect
4 - Navigate To StoreFront
5 - Fill in Search Field, Submit Search Request
6 - Assert Current Url
Questions or comments
Contribution checklist (*)