#26583 Tier pricing save percent showing logic updated in product detail page

[srsathish92]

Description (*)

Tier pricing save percentage showing logic updated in product detail page

Fixed Issues (if relevant)

#26583

Manual testing scenarios (*)

1. Create simple product with
   Price - $100.00
   Special price - $65.00
2. Add tier price rule
   For 2 (Qty) - Fixed $40.00
   For 3 (Qty) - Percentage 36%
3. Save the product.
4. View the product in front end

Questions or comments

If any please let me know your feedback

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[srsathish92]

@magento-engcom-team can you please validate this PR?

[srsathish92]

@lenaorobei @lbajsarowicz can you please validate this PR?

[ihor-sviziev]

@magento give me test instance

[magento-engcom-team]

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @ihor-sviziev, here is your new Magento instance.
Admin access: https://pr-26584.instances.magento-community.engineering/admin_9fca
Login: ff04e3d7 Password: be745aa67873
Instance will be terminated in up to 3 hours.

[ihor-sviziev]

Your changes looks good for me, and fix works fine:

Before ❌:

After ✔:

Could you cover your changes with MFTF test like this?

• Create product with regular price=100$, special price=65$, tier price qty from 3=36%.
• Navigate to product page
• Check if on product page we can see message "Buy 3 for $64.00 each and save 2%"

[engcom-Charlie]

Hi, @ihor-sviziev I'll take care of automated tests.

[ihor-sviziev]

@engcom-Charlie in general looks good, let's wait for test results

[lbajsarowicz]

Sorry, I'm very demanding when it comes to MFTF.
Please review the comments.

Our main recommendation is that Tests should be made mostly of reusable blocks --- Action Groups.

[ihor-sviziev]

@engcom-Charlie please review comments from @lbajsarowicz above and failing functional tests - looks like special price isn't applied. Please fix it

[lbajsarowicz]

For failing tests you need to reindex using cron

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6914 has been created to process this Pull Request

[ihor-sviziev]

@engcom-Charlie thank you for covering this PR with functional tests!

[engcom-Alfa]

✔️ QA Passed

Before:

After:

[m2-assistant]

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.