Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test for Magento\LayeredNavigation\Observer\Edit\Tab\Front\ProductAttributeFormBuildFrontTabObserver #26617

Merged
merged 5 commits into from Feb 21, 2020
Merged

Unit Test for Magento\LayeredNavigation\Observer\Edit\Tab\Front\ProductAttributeFormBuildFrontTabObserver #26617

merged 5 commits into from Feb 21, 2020

Conversation

karyna-tsymbal-atwix
Copy link
Contributor

Description (*)

Covers Magento\LayeredNavigation\Observer\Edit\Tab\Front\ProductAttributeFormBuildFrontTabObserver class with a unit test.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 31, 2020

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 31, 2020
lbajsarowicz
lbajsarowicz suggested changes Feb 1, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix static tests.

@ghost ghost assigned lbajsarowicz Feb 1, 2020
@engcom-Echo engcom-Echo self-assigned this Feb 6, 2020
@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Feb 14, 2020
dmytro-ch
dmytro-ch requested changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @karyna-tsymbal-atwix, could you please fix minor CR recommendations?
Thank you!

...vigation/Test/Unit/Observer/Edit/Tab/Front/ProductAttributeFormBuildFrontTabObserverTest.php Outdated
->willReturn(true);

$fieldsetMock = $this->createMock(Fieldset::class);
$fieldsetMock->expects(self::exactly(3))->method('addField');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace the static method's call for consistency with other stubs definition.

Suggested change
$fieldsetMock->expects(self::exactly(3))->method('addField');
$fieldsetMock->expects($this->exactly(3))->method('addField');

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmytro-ch thanks for the note, fixed!

...vigation/Test/Unit/Observer/Edit/Tab/Front/ProductAttributeFormBuildFrontTabObserverTest.php Outdated
/**
* Test case when module output is disabled
*/
public function testExecuteWhenOutputDisabled()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not critical but would be preferred to follow the strict type of definition for methods signature.

Suggested change
public function testExecuteWhenOutputDisabled()
public function testExecuteWhenOutputDisabled(): void

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ghost ghost assigned dmytro-ch Feb 14, 2020
@engcom-Bravo engcom-Bravo self-assigned this Feb 17, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6912 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

The test is added and pass
ProductAttributeGridObserverTest

magento-engcom-team pushed a commit that referenced this pull request Feb 21, 2020
@VladimirZaets
ENGCOM-6912: Unit Test for Magento\LayeredNavigation\Observer\Edit\Ta…
bcae7e3 
…b\Front\ProductAttributeFormBuildFrontTabObserver #26617
@magento-engcom-team magento-engcom-team merged commit 5e66998 into magento:2.4-develop Feb 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 21, 2020

Hi @karyna-tsymbal-atwix, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@karyna-tsymbal-atwix karyna-tsymbal-atwix deleted the unit-test-layered-navigation-productAttributeFormBuildFrontTabObserver branch August 6, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz requested changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@dmytro-ch dmytro-ch

@engcom-Bravo engcom-Bravo

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: LayeredNavigation Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@karyna-tsymbal-atwix @magento-engcom-team @engcom-Bravo @lbajsarowicz @dmytro-ch @engcom-Echo