Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover CartTotalRepositoryPlugin by unit test and correct docblock #26619

Merged
merged 7 commits into from
Mar 2, 2020
Merged

Cover CartTotalRepositoryPlugin by unit test and correct docblock #26619

merged 7 commits into from
Mar 2, 2020

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Jan 31, 2020

Description (*)

Cover the Plugin CartTotalRepositoryPlugin by Unit Test
correct docblock origin plugin class

Related Pull Requests

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 31, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

lbajsarowicz
lbajsarowicz suggested changes Feb 1, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix static tests.

@ghost ghost assigned lbajsarowicz Feb 1, 2020
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 1, 2020

@lbajsarowicz i have checked and fix for static tests

lbajsarowicz
lbajsarowicz suggested changes Feb 1, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes to be introduced.

app/code/Magento/Multishipping/Model/Cart/CartTotalRepositoryPlugin.php Outdated Show resolved Hide resolved
app/code/Magento/Multishipping/Test/Unit/Model/Cart/CartTotalRepositoryPluginTest.php Outdated Show resolved Hide resolved
app/code/Magento/Multishipping/Test/Unit/Model/Cart/CartTotalRepositoryPluginTest.php Outdated Show resolved Hide resolved
mrtuvn
mrtuvn commented Feb 12, 2020
View reviewed changes
Copy link
Contributor Author

@mrtuvn mrtuvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbajsarowicz can you recheck this

lbajsarowicz
lbajsarowicz suggested changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Really last thing to finish.

app/code/Magento/Multishipping/Test/Unit/Model/Cart/CartTotalRepositoryPluginTest.php Outdated Show resolved Hide resolved
@mrtuvn
Merge remote-tracking branch 'upstream/2.4-develop' into 2.4-develop
e2c403f
@mrtuvn
Cover CartTotalRepositoryPlugin by unit test and correct docblock
ad8fea6 
Fix static tests

Update commit with meaningful test name

Remove unnecessary assignment stub in test code
@mrtuvn mrtuvn force-pushed the coverage-test-multishipping-cart-totals-plugin branch from 5446a0e to ad8fea6 Compare February 13, 2020 07:22
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 17, 2020

@lbajsarowicz can we have new process on this PR. Still one failed functional tests !
I have checked and see problem in
app/code/Magento/CustomerBalance/Test/Mftf/Test/StorefrontOptionRemoveStoreCreditPaymentPageTest.xml

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 29, 2020

@lbajsarowicz can you review last changes again ?

lbajsarowicz
lbajsarowicz approved these changes Feb 29, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7009 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Mar 2, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Mar 2, 2020
@engcom-Golf engcom-Golf self-assigned this Mar 2, 2020
@lbajsarowicz
Copy link
Contributor

@engcom-Golf Could you explain why it was working before, but after these changes, we need to add View Model?

@engcom-Golf
Copy link
Contributor

engcom-Golf commented Mar 2, 2020 •
edited
Loading

@lbajsarowicz bug found by QA process, issue exist in dev branch

lbajsarowicz
lbajsarowicz approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Green from me, then.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7009 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

magento-engcom-team pushed a commit that referenced this pull request Mar 2, 2020
@VladimirZaets
ENGCOM-7009: Cover CartTotalRepositoryPlugin by unit test and correct…
47233a6 
… docblock #26619
@magento-engcom-team magento-engcom-team merged commit 2cbe34f into magento:2.4-develop Mar 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 2, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mrtuvn mrtuvn deleted the coverage-test-multishipping-cart-totals-plugin branch June 7, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Multishipping Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mrtuvn @magento-engcom-team @lbajsarowicz @engcom-Golf @engcom-Alfa @Nazar65