Use '===' operator to check if file was written.

[vovayatsyuk]

Description

This commit prevents incorrect logic when writing empty string (0 bytes).

See manuals for corresponding functions:

• file_put_contents
• copy

Manual testing scenarios

To test this PR, you need to edit some PHP code. The easiest way is to edit some core code:

1. Open Magento/Catalog/Controller/Adminhtml/Product/Index.php

2. Add the following code at the top of execute method:

   $result = \Magento\Framework\App\ObjectManager::getInstance()
       ->get(\Magento\Framework\Filesystem\Driver\File::class)
       ->filePutContents(BP . '/var/log/system.log', '');
   
   echo "Bytes written: " . $result;
   die;

3. Now open Catalog > Products page.

4. An exception will be thrown: "The specified "var/log/system.log" file couldn't be written."

5. Apply the patch and you'll see "Bytes written: 0" message instead of exception.

Questions or comments

Make sure that your web server has write access to the "var/log/system.log" file.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @vovayatsyuk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

Hi @vovayatsyuk,
Could you fix failing static tests in files that you’ve touched and cover your changes with some kind of tests? I think integration tests is most suitable here

[engcom-Echo]

I will take care of test coverage.

[ihor-sviziev]

Functional test failures not related to changes from this pr

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6896 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @vovayatsyuk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.