-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests for Magento\Csp\Model\Mode\ConfigManager and Magento\Csp\Observer\Render #26770
Unit tests for Magento\Csp\Model\Mode\ConfigManager and Magento\Csp\Observer\Render #26770
Conversation
Hi @karyna-tsymbal-atwix. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another good contribution, actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @karyna-tsymbal-atwix, could you please fix the merging conflicts? Looks like the Magento\Csp\Model\Mode\ConfigManager
class has been already covered by Unit Test.
# Conflicts: # app/code/Magento/Csp/Test/Unit/Model/Mode/ConfigManagerTest.php
…Magento\Csp\Observer\Render #26770
Hi @karyna-tsymbal-atwix, thank you for your contribution! |
Description (*)
Covers \Magento\Csp\Model\Mode\ConfigManager and \Magento\Csp\Observer\Render with a unit tests.
Contribution checklist (*)