Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for Magento\Csp\Model\Mode\ConfigManager and Magento\Csp\Observer\Render #26770

Conversation

karyna-tsymbal-atwix
Copy link
Contributor

Description (*)

Covers \Magento\Csp\Model\Mode\ConfigManager and \Magento\Csp\Observer\Render with a unit tests.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2020

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Csp Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 8, 2020
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good contribution, actually.

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

The added tests pass
confmanag

render

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @karyna-tsymbal-atwix, could you please fix the merging conflicts? Looks like the Magento\Csp\Model\Mode\ConfigManager class has been already covered by Unit Test.

# Conflicts:
#	app/code/Magento/Csp/Test/Unit/Model/Mode/ConfigManagerTest.php
@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @karyna-tsymbal-atwix, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@karyna-tsymbal-atwix karyna-tsymbal-atwix deleted the unit-test-csp-Render-and-ConfigManager branch August 6, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: test coverage Component: Csp Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants