Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test for ProductProcessUrlRewriteRemovingObserver #26912

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Unit test for ProductProcessUrlRewriteRemovingObserver #26912

merged 2 commits into from
Feb 26, 2020

Conversation

mmezhensky
Copy link
Contributor

Description (*)

This PR adds unit test that covers Magento\CatalogUrlRewrite\Observer\ProductProcessUrlRewriteRemovingObserver

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 18, 2020

Hi @mmezhensky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: CatalogUrlRewrite Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 18, 2020
@eduard13 eduard13 self-assigned this Feb 19, 2020
eduard13
eduard13 requested changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mmezhensky, thank you for your contribution. Could you please check the comments below?
Also, may I ask you to cover another test case when the product doesn't have an ID?
Thank you.

...agento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteRemovingObserverTest.php Outdated Show resolved Hide resolved
...agento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteRemovingObserverTest.php Outdated Show resolved Hide resolved
...agento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteRemovingObserverTest.php Outdated Show resolved Hide resolved
...agento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteRemovingObserverTest.php Show resolved Hide resolved
...agento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteRemovingObserverTest.php Outdated Show resolved Hide resolved
@eduard13 eduard13 added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: test coverage labels Feb 19, 2020
@eduard13
Copy link
Contributor

@magento run all tests

eduard13
eduard13 previously approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
Thank you.

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-6943 has been created to process this Pull Request

@ghost ghost dismissed eduard13’s stale review February 20, 2020 13:10

Pull Request state was updated. Re-review required.

@eduard13 eduard13 self-requested a review February 20, 2020 13:11
@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-6943 has been created to process this Pull Request

@eduard13 eduard13 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Feb 21, 2020
@eduard13 eduard13 self-requested a review February 22, 2020 10:41
@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-6943 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Feb 24, 2020
@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@engcom-Echo engcom-Echo self-assigned this Feb 24, 2020
@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-6943 has been created to process this Pull Request

@eduard13
Copy link
Contributor

eduard13 commented Feb 24, 2020 •
edited
Loading

Hi @engcom-Echo , looks like there were some labels that were not removed after review, that was the reason of re-requesting my review here?

@engcom-Delta
Copy link
Contributor

Hi @eduard13 there was misconfiguration with labels. Thanks for approve

magento-engcom-team pushed a commit that referenced this pull request Feb 26, 2020
@slavvka
ENGCOM-6943: Unit test for ProductProcessUrlRewriteRemovingObserver #…
c1c060b 
…26912
@magento-engcom-team magento-engcom-team merged commit 8be8e9a into magento:2.4-develop Feb 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2020

Hi @mmezhensky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

Assignees

@eduard13 eduard13

@engcom-Delta engcom-Delta

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: CatalogUrlRewrite Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmezhensky @eduard13 @magento-engcom-team @engcom-Delta @engcom-Echo