-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test for ProductProcessUrlRewriteRemovingObserver #26912
Unit test for ProductProcessUrlRewriteRemovingObserver #26912
Conversation
…oductProcessUrlRewriteRemovingObserver
Hi @mmezhensky. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mmezhensky, thank you for your contribution. Could you please check the comments below?
Also, may I ask you to cover another test case when the product doesn't have an ID?
Thank you.
...agento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteRemovingObserverTest.php
Outdated
Show resolved
Hide resolved
...agento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteRemovingObserverTest.php
Outdated
Show resolved
Hide resolved
...agento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteRemovingObserverTest.php
Outdated
Show resolved
Hide resolved
...agento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteRemovingObserverTest.php
Show resolved
Hide resolved
...agento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteRemovingObserverTest.php
Outdated
Show resolved
Hide resolved
…riteRemovingObserver
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Thank you.
Hi @eduard13, thank you for the review. |
Pull Request state was updated. Re-review required.
Hi @eduard13, thank you for the review. |
Hi @eduard13, thank you for the review. |
Notice: QA not applicable |
Hi @eduard13, thank you for the review. |
Hi @engcom-Echo , looks like there were some labels that were not removed after review, that was the reason of re-requesting my review here? |
Hi @eduard13 there was misconfiguration with labels. Thanks for approve |
Hi @mmezhensky, thank you for your contribution! |
Description (*)
This PR adds unit test that covers Magento\CatalogUrlRewrite\Observer\ProductProcessUrlRewriteRemovingObserver
Contribution checklist (*)