Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF FIX: Remove Customer by e-mail does not filter by e-mail #27000

Merged
merged 3 commits into from
Mar 25, 2020
Merged

MFTF FIX: Remove Customer by e-mail does not filter by e-mail #27000

merged 3 commits into from
Mar 25, 2020

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Feb 25, 2020 •
edited by slavvka
Loading

Description (*)

Currently, this Action Group works by coincidence. When there's more than 1 Customer, it's going to remove the first one that is displayed in grid.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Create 2 Customers with MFTF
  2. Remove 2nd by its e-mail
  3. Expect 1st one is untouched.

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 25, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev ihor-sviziev self-assigned this Feb 25, 2020
@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 25, 2020
ihor-sviziev
ihor-sviziev previously approved these changes Feb 25, 2020
View reviewed changes
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6976 has been created to process this Pull Request

@lbajsarowicz
Copy link
Contributor Author

Bump! Can this be merged?

@engcom-Alfa engcom-Alfa self-assigned this Mar 11, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Mar 11, 2020
@engcom-Charlie engcom-Charlie added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Mar 11, 2020
@slavvka
Copy link
Member

slavvka commented Mar 15, 2020

@magento run Functional Tests EE

@slavvka
Copy link
Member

slavvka commented Mar 16, 2020

@lbajsarowicz Hey, the same EE MFTF test is failing al the time. Looks like it may be related to your code change

@slavvka
Copy link
Member

slavvka commented Mar 16, 2020

@lbajsarowicz I do understand that it's weird. But I have reran the builds around 10 times and al the time there were failing on your PR :(

@lbajsarowicz
Copy link
Contributor Author

lbajsarowicz commented Mar 16, 2020 •
edited
Loading

This is exactly the same as the situation that took place in January.
When I fix 1 Functional Test, other 3 will fail.

image

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B

@lbajsarowicz
Copy link
Contributor Author

The failing tests are fixed in separate PR: magento/magento2-page-builder#408

@lenaorobei
Copy link
Contributor

@magento run all tests

@ghost ghost assigned lenaorobei Mar 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6976 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Echo engcom-Echo self-assigned this Mar 23, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@magento-engcom-team magento-engcom-team added this to Merge in Progress in Pull Requests Dashboard Mar 24, 2020
magento-engcom-team pushed a commit that referenced this pull request Mar 25, 2020
@slavvka
ENGCOM-6976: MFTF FIX: Remove Customer by e-mail does not filter by e…
3462dbf 
…-mail #27000
@magento-engcom-team magento-engcom-team merged commit de874d1 into magento:2.4-develop Mar 25, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 25, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Mar 25, 2020
@magento-engcom-team magento-engcom-team removed this from Recently Merged in Pull Requests Dashboard Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavvka slavvka slavvka requested changes

@lenaorobei lenaorobei lenaorobei approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev left review comments

Assignees

@ihor-sviziev ihor-sviziev

@slavvka slavvka

@lenaorobei lenaorobei

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Customer Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@lbajsarowicz @magento-engcom-team @engcom-Alfa @slavvka @ihor-sviziev @lenaorobei @engcom-Echo @engcom-Charlie