-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magento/magento2#: Remove a redundant PHP5 directives from .htaccess #27114
magento/magento2#: Remove a redundant PHP5 directives from .htaccess #27114
Conversation
Hi @atwixfirster. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @rogyar, thank you for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Thanks for contribution.
Could you also check other projects (PageBuilder / EE / B2B) for such entries in .htaccess files?
Hi @lbajsarowicz, thank you for the review. |
✔️ QA Passed |
Hi @atwixfirster, thank you for your contribution! |
Description (*)
PR removes directives for
mod_php5.c
from.htaccess
file since Magento 2 supports > PHP 7.x.xRelated Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)