Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

27027 added date format adjustment for 'validate-dob' rule #27149

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Mar 4, 2020

Description

Added date format adjustment for 'validate-dob' rule

Fixed Issues

#27027

Manual testing scenarios

See issue description from #27027.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 4, 2020

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Customer Component: Ui Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 4, 2020
@rogyar rogyar self-assigned this Mar 4, 2020
@sergiy-v sergiy-v force-pushed the 27027-dob-validation-adjustments branch from 1e1cf72 to 1c35d06 Compare March 4, 2020 09:06
@sergiy-v sergiy-v force-pushed the 27027-dob-validation-adjustments branch from 655e1ac to 8f81132 Compare March 4, 2020 09:52
@rogyar rogyar added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: MFTF test coverage labels Mar 4, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7036 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

No error appears after switching to the PR
customer_dofb

@m2-assistant
Copy link

m2-assistant bot commented Mar 12, 2020

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@nelero
Copy link

nelero commented Mar 20, 2020

Thanks
how to use it with cweagans/composer-patches ? like in this message #26675 (comment)
is there anything to remove in paths of diff file ?

Thanks

@sergiy-v
Copy link
Contributor Author

Thanks
how to use it with cweagans/composer-patches ? like in this message #26675 (comment)
is there anything to remove in paths of diff file ?

Thanks

Hello @nelero,
Not sure I 100% understand what are you looking for.
According to instruction for patch applying from your comment you are looking for PR diff, you can get by the following link.
https://github.com/magento/magento2/pull/27149.diff

Thank you.

@nelero
Copy link

nelero commented Mar 23, 2020

hi @sergiy-v ,
thanks for the link. My question was if there was anything to remove in the paths of the content of the diff file. If you have a look at the #26675 (comment) (the comment pointed), you'll see that we have to remove some parts of the paths written in the diff file in order to apply it correctly.
So i was wondering if we had to do the same with this diff file.
Thanks

@magento-engcom-team magento-engcom-team added this to Recently Merged in Pull Requests Dashboard Mar 24, 2020
@nelero
Copy link

nelero commented Mar 26, 2020

hi @sergiy-v , i found my way to apply this patch with cweagans/composer-patches

  1. Create the patches/composer folder at the magento root directory
  2. copy first part of diff file, related to magento/module-customer in a file in this folder, i.e. 27149-customer.diff
  3. Copy the last part of diff file, related to magento/module-ui in another file 27149-ui.diff
  4. In those 2 files, remove app/code/Magento/Customer/ and app/code/Magento/Ui/ wherever it appears
  5. Add these lines in the composer.json file :
"extra": {
         "magento-force": "override",
         "composer-exit-on-patch-failure": true,
         "patches": {
             "magento/module-customer":{
                 "1.0": "patches/composer/27149-customer.diff"
             },
             "magento/module-ui":{
                 "1.0": "patches/composer/27149-ui.diff"
             }
 
         }
     } 
  1. Run composer -v install
  2. Run composer update --lock

@sergiy-v
Copy link
Contributor Author

hi @sergiy-v , i found my way to apply this patch with cweagans/composer-patches

Hello @nelero, nice to hear that, thank you for your update!

@magento-engcom-team magento-engcom-team removed this from Recently Merged in Pull Requests Dashboard Apr 25, 2020
@matthewhaworth
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @matthewhaworth. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @matthewhaworth, here is your Magento instance.
Admin access: https://i-27149-2-4-develop.instances.magento-community.engineering/admin_4b80
Login: f55d572f Password: 65e79e93e371
Instance will be terminated in up to 3 hours.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: MFTF test coverage Component: Customer Component: Ui Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants