Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFTF: Replace fragile test AdminLoginTest with AdminLoginSuccessfulTest #27255

Merged

Conversation

lbajsarowicz
Copy link
Contributor

Description (*)

Verify that Admin is logged in successfully not by the URL, but by the User block in top right corner.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fragile tests when you change Admin Path or default dashboard page.

Manual testing scenarios (*)

  1. Run MFTF

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 12, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@lbajsarowicz
Copy link
Contributor Author

@okolesnyk I'd prefer to have own TestCaseID for the failure scenario if you have some?

@dmytro-ch dmytro-ch added Award: category of expertise Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage labels Mar 12, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7081 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie
Copy link
Contributor

Failed functional tests not related to the changes in this PR.

magento-engcom-team pushed a commit that referenced this pull request Mar 19, 2020
@magento-engcom-team magento-engcom-team merged commit 65374be into magento:2.4-develop Mar 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 19, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants