Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFTF: Test isolation, consistent naming (backwards-compatible) #27273

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Mar 13, 2020

Description (*)

Currently when you run vendor/bin/mftf run:test -r StorefrontResetCustomerPasswordSuccessTest StorefrontResetCustomerPasswordFailedTest, as a result second test will fail. This is because of lack of isolation between these tests.

Conditions that should be fulfilled are:

  1. IP Address should not affect the results of tests
  2. Each of tests should "clean up" after itself.

Also renamed one of the tests to be consistent, replaced manual actions with Action Groups.
Old name was moved to the _Deprecated_Test.xml that is still available for those who extend old test, with deprecated annotation.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Execute functional tests

Questions or comments

CC: @okolesnyk

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 13, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@lbajsarowicz lbajsarowicz changed the title MFTF: Test isolation, consistent naming (backwards-compatible manner) MFTF: Test isolation, consistent naming (backwards-compatible) Mar 13, 2020
@dmytro-ch dmytro-ch self-assigned this Mar 13, 2020
@dmytro-ch dmytro-ch added Award: category of expertise Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix labels Mar 13, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7092 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA passed

# Conflicts:
#	app/code/Magento/Customer/Test/Mftf/Test/_Deprecated_Test.xml
@engcom-Charlie
Copy link
Contributor

Failed functional tests not related to the changes in this PR.

@m2-assistant
Copy link

m2-assistant bot commented Mar 19, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to Recently Merged in Pull Requests Dashboard Mar 24, 2020
@magento-engcom-team magento-engcom-team removed this from Recently Merged in Pull Requests Dashboard Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants