-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFTF: Test isolation, consistent naming (backwards-compatible) #27273
MFTF: Test isolation, consistent naming (backwards-compatible) #27273
Conversation
Hi @lbajsarowicz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @dmytro-ch, thank you for the review. |
✔️ QA passed |
# Conflicts: # app/code/Magento/Customer/Test/Mftf/Test/_Deprecated_Test.xml
Failed functional tests not related to the changes in this PR. |
Hi @lbajsarowicz, thank you for your contribution! |
Description (*)
Currently when you run
vendor/bin/mftf run:test -r StorefrontResetCustomerPasswordSuccessTest StorefrontResetCustomerPasswordFailedTest
, as a result second test will fail. This is because of lack of isolation between these tests.Conditions that should be fulfilled are:
Also renamed one of the tests to be consistent, replaced manual actions with Action Groups.
Old name was moved to the
_Deprecated_Test.xml
that is still available for those who extend old test, withdeprecated
annotation.Related Pull Requests
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
Questions or comments
CC: @okolesnyk
Contribution checklist (*)