Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set collection if there is not any collection before #27313

Closed
wants to merge 17 commits into from
Closed

Set collection if there is not any collection before #27313

wants to merge 17 commits into from

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Mar 17, 2020 •
edited by engcom-Foxtrot

Description (*)

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/516

Fixed Issues (if relevant)

1.https://github.com/magento/partners-magento2ee/issues/64

Manual testing scenarios (*)

Login to admin -> Go to catalog -> Category
Under products in category section
Filterable section is available and filtrable

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Set collection if there is not any collection before #32229: Set collection if there is not any collection before

@m2-assistant
Copy link

m2-assistant bot commented Mar 17, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@engcom-Golf
Copy link
Contributor

@magento run all tests

lbajsarowicz
lbajsarowicz suggested changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing Unit Tests and Integration Tests

@ghost ghost assigned lbajsarowicz Mar 17, 2020
@engcom-Golf
Copy link
Contributor

engcom-Golf commented Mar 18, 2020 •
edited

Please fix the failing Unit Tests and Integration Tests

@lbajsarowicz already in progress

@engcom-Golf engcom-Golf changed the title Set collection if there is not any collection before [WIP] Set collection if there is not any collection before Mar 18, 2020
@engcom-Golf engcom-Golf changed the title [WIP] Set collection if there is not any collection before Set collection if there is not any collection before Mar 18, 2020
@engcom-Golf engcom-Golf added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Mar 19, 2020
@engcom-Golf
Copy link
Contributor

@lbajsarowicz ✔️

lbajsarowicz
lbajsarowicz previously approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using different formatting for the filters block. Also instead of coalescing - use array for filters.

app/code/Magento/Catalog/Block/Adminhtml/Category/Tab/Product.php Outdated Show resolved Hide resolved
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7149 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Mar 20, 2020
@ghost ghost dismissed lbajsarowicz’s stale review March 20, 2020 12:11

Pull Request state was updated. Re-review required.

@magento-engcom-team magento-engcom-team added this to Changes Requested in Pull Requests Dashboard Mar 24, 2020
@m2-community-project m2-community-project bot moved this from Merge in Progress to Ready for Testing in High Priority Pull Requests Dashboard Feb 19, 2021
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Feb 22, 2021
engcom-Bravo
engcom-Bravo requested changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@engcom-Bravo engcom-Bravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ QA failed

Tested together with the related EE PR

There is an unneeded filterable field without name
unneeded

@m2-community-project m2-community-project bot moved this from Testing in Progress to Changes Requested in High Priority Pull Requests Dashboard Feb 22, 2021
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

1 similar comment
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

4 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Foxtrot engcom-Foxtrot moved this from Changes Requested to Pending Review in High Priority Pull Requests Dashboard May 17, 2021
@joshuaswarren
Copy link

@Nazar65 - thank you for your work on this pull request back in 2020! It's actually one of the oldest open pull requests on the Magento 2 repository now, and I'm trying to understand just what's going on with some of these oldest pull requests. I know a lot has happened since in 2020, so I'm curious if you have an opinion on if this pull request still ought to be considered for merging? Are you able to address the changes

@Nazar65 Nazar65 closed this by deleting the head repository Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Bravo engcom-Bravo engcom-Bravo requested changes

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@sidolov sidolov Awaiting requested review from sidolov

Assignees

@lbajsarowicz lbajsarowicz

@sidolov sidolov

@engcom-Alfa engcom-Alfa

@engcom-Bravo engcom-Bravo

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Priority: P2 A defect with this priority could have functionality issues which are not to expectations. QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Set collection if there is not any collection before