Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFTF: Refactor amOnPage for Admin product edit page #27378

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Mar 20, 2020

Description (*)

Renamed GoToProductPageViaIDActionGroup to the name that follows Magento best practices AdminProductPageOpenByIdActionGroup, replaced all <amOnPage calls to Action Groups

Won't fix:
Quite often problem of flaky tests in Magento CI is timeout on opening different pages. Most recent example is:
image
image

You can see, that assertion (expectation) of loaded page failed, but the page is still loading. That's why I decided to add waitForPageLoad. But not only!

Related Pull Requests

Fixed Issues (if relevant)

Magento CI failures

Manual testing scenarios (*)

PR should pass.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 20, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev ihor-sviziev self-assigned this Mar 21, 2020
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general changes looks good, please check my suggestion

@lbajsarowicz lbajsarowicz changed the title MFTF: Refactor + bugfix for amOnPage timeout MFTF: Refactor amOnPage for Admin product edit page Mar 21, 2020
@ihor-sviziev ihor-sviziev added Award: bug fix improvement Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Mar 21, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7169 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team added this to Ready for Testing in Pull Requests Dashboard Mar 24, 2020
@engcom-Alfa engcom-Alfa self-assigned this Mar 25, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Mar 25, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Mar 25, 2020
@engcom-Kilo engcom-Kilo self-assigned this Mar 25, 2020
@engcom-Kilo
Copy link
Contributor

Failed Functional tests & Static tests not related to the changes in this PR

@engcom-Kilo engcom-Kilo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Mar 25, 2020
@magento-engcom-team magento-engcom-team merged commit c7e5171 into magento:2.4-develop Mar 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 26, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Mar 26, 2020
@magento-engcom-team magento-engcom-team removed this from Recently Merged in Pull Requests Dashboard Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment