-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFTF: Refactor amOnPage
for Admin product edit page
#27378
MFTF: Refactor amOnPage
for Admin product edit page
#27378
Conversation
Hi @lbajsarowicz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general changes looks good, please check my suggestion
app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductPageOpenByIdActionGroup.xml
Outdated
Show resolved
Hide resolved
amOnPage
timeoutamOnPage
for Admin product edit page
Hi @ihor-sviziev, thank you for the review. |
✔️ QA Passed |
Failed Functional tests & Static tests not related to the changes in this PR |
Hi @lbajsarowicz, thank you for your contribution! |
Description (*)
Renamed
GoToProductPageViaIDActionGroup
to the name that follows Magento best practicesAdminProductPageOpenByIdActionGroup
, replaced all<amOnPage
calls to Action GroupsWon't fix:
![image](https://user-images.githubusercontent.com/1639941/77214129-dc1f3100-6b0d-11ea-9847-38d2afc9d039.png)
![image](https://user-images.githubusercontent.com/1639941/77214138-e9d4b680-6b0d-11ea-8546-e8805bc45602.png)
Quite often problem of flaky tests in Magento CI is timeout on opening different pages. Most recent example is:
You can see, that assertion (expectation) of loaded page failed, but the page is still loading. That's why I decided to add
waitForPageLoad
. But not only!Related Pull Requests
Fixed Issues (if relevant)
Magento CI failures
Manual testing scenarios (*)
PR should pass.
Questions or comments
Contribution checklist (*)