26214: Bundle Product / Create / Price validation for dynamic price

[phuocnh]

Description (*)

• Fixed Bundle Product / Create / Price validation for dynamic price

Fixed Issues (if relevant)

1. Bundle Product / Create / Price validation for dynamic price #26214: Bundle Product / Create / Price validation for dynamic price

Manual testing scenarios (*)

1. Enter "New Product / Bundle" form
2. Turn off "Dynamic price"
3. Enter the price and remove it. You'll see a validation error.
4. Turn on "Dynamic price". You'll see remove a validation error.

video fixed https://youtu.be/zyPJw6udqO0

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[eduard13]

Hi @phuocnh, thank you for your contribution. Due to Magento Definition of Done the changes should be covered by tests. Could you please cover your fix by a MFTF test and also fix the static tests?
Thank you.

[phuocnh]

Hi @eduard13, please check again
thanks

[eduard13]

Hi @phuocnh, as I mentioned previously, your changes have to be covered by an automated test. I'd suggest covering by a simple MFTF test.

[eduard13]

Hi @phuocnh, are you willing to continue the progress on this one? There is no much left till the end, as you should only cover your fix by a test.
Please let me know if you need any assistance.
Thank you.

[phuocnh]

Hi @eduard13

now all checks have passed

But I have problem when install MFTF test with branch 2.4-develop and flow by document link https://devdocs.magento.com/mftf/docs/getting-started.html. I think it only support with Magento 2.3.x

thanks

[eduard13]

Closing this one, as it looks like the repo doesn't exist anymore.

[m2-assistant]

Hi @phuocnh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.