-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ActionInterface for /checkout/sidebar/removeItem #27463
Implement ActionInterface for /checkout/sidebar/removeItem #27463
Conversation
Hi @Bartlomiejsz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @Bartlomiejsz. Thank you, good job. I would suggest rebuilding the unit test and use data providers since we have a plenty of duplicated lines there. However, overcomplicating such PRs with unit tests refactoring is not necessary. |
Hi @rogyar, thank you for the review. |
Failing functional tests are not related to the current PR |
✔️ QA Passed |
Hi @Bartlomiejsz, thank you for your contribution! |
Description (*)
This is a part of the process of introducing implementations of
ActionInterface
.Related Pull Requests
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
N/A
Questions or comments
Contribution checklist (*)