Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tests for Magento\Framework\Stdlib\DateTime\DateTime #27492

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Fixed tests for Magento\Framework\Stdlib\DateTime\DateTime #27492

merged 2 commits into from
Apr 2, 2020

Conversation

andrewbess
Copy link
Contributor

Description (*)

This PR fixes the tests for Magento\Framework\Stdlib\DateTime\DateTime. Daylight Saving Time was not considered there.
daylight-saving-time-is-not-effect
daylight-saving-time-is-in-effect

I have found it when changed my last PR. The first commit passed the tests well, but the second did not.
allure-report-error

Related Pull Requests

#27481 and the other futured after him

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2020

Hi @andrewbess. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Stdlib Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 30, 2020
@eduard13 eduard13 self-assigned this Mar 30, 2020
@sergiy-v sergiy-v mentioned this pull request Mar 30, 2020
Merged
4 tasks
eduard13
eduard13 approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-7224 has been created to process this Pull Request
✳️ @eduard13, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@eduard13 eduard13 added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Mar 30, 2020
ihor-sviziev
ihor-sviziev requested changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrewbess,
Could you fix merge conflict?

Merge remote-tracking branch 'remotes/upstream/2.4-develop' into bugf…
7ee81db 
…ix/fix-test-for-datetime

# Conflicts:
#	lib/internal/Magento/Framework/Stdlib/Test/Unit/DateTime/DateTimeTest.php
@andrewbess
Copy link
Contributor Author

Hi @andrewbess,
Could you fix merge conflict?

Hello @ihor-sviziev
I have fixed the merge conflict.
Please check.
Thank you in advance

@lenaorobei lenaorobei added this to Pending Review in Pull Requests Dashboard Mar 31, 2020
@lenaorobei lenaorobei moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Mar 31, 2020
@ghost ghost moved this from Ready for Testing to Pending Review in Pull Requests Dashboard Mar 31, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Mar 31, 2020
@ghost ghost assigned lenaorobei Mar 31, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7224 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Apr 1, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 1, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Apr 1, 2020
@engcom-Echo engcom-Echo self-assigned this Apr 1, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Pending Approval in Pull Requests Dashboard Apr 1, 2020
@ghost ghost moved this from Pending Approval to Extended Testing (optional) in Pull Requests Dashboard Apr 1, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Apr 1, 2020
magento-engcom-team pushed a commit that referenced this pull request Apr 2, 2020
@slavvka
ENGCOM-7224: Fixed tests for Magento\Framework\Stdlib\DateTime\DateTime
9902028 
#27492
@magento-engcom-team magento-engcom-team merged commit 62120b2 into magento:2.4-develop Apr 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 2, 2020

Hi @andrewbess, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Apr 2, 2020
@magento-engcom-team magento-engcom-team removed this from Recently Merged in Pull Requests Dashboard May 1, 2020
@andrewbess andrewbess deleted the bugfix/fix-test-for-datetime branch October 28, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev requested changes

@eduard13 eduard13 eduard13 approved these changes

@lenaorobei lenaorobei lenaorobei approved these changes

@ishakhsuvarov ishakhsuvarov Awaiting requested review from ishakhsuvarov

Assignees

@eduard13 eduard13

@lenaorobei lenaorobei

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Stdlib Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@andrewbess @magento-engcom-team @engcom-Alfa @ihor-sviziev @eduard13 @lenaorobei @engcom-Echo