Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong position of button list when load "New Attribute" page #27574

Conversation

edenduong
Copy link
Contributor

@edenduong edenduong commented Apr 4, 2020

Description (*)

Let check this gif:

wrong_position

We can see, after 1 seconds, the button list re-arranged.

image

to

image

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to backend, create new product
  2. Fill required field, go to "Create Configurations"
  3. Create New Attribute
  4. Look at the position of the button "Reset" and "Save Attribute"
    5, It should be:

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix wrong position of button list when load "New Attribute" page #29597: Fix wrong position of button list when load "New Attribute" page

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2020

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@edenduong
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-27574.instances.magento-community.engineering/admin_cdfb
Login: 7828b783 Password: 75d6f0532437
Instance will be terminated in up to 3 hours.

@edenduong
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-27574.instances.magento-community.engineering/admin_c8e7
Login: a2ee2be9 Password: 1bf3c0f1526d
Instance will be terminated in up to 3 hours.

@sidolov
Copy link
Contributor

sidolov commented Aug 17, 2020

@magento create issue

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 17, 2020
@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. and removed Priority: P3 May be fixed according to the position in the backlog. labels Sep 14, 2020
@ihor-sviziev ihor-sviziev self-assigned this Sep 29, 2020
@ihor-sviziev ihor-sviziev moved this from Pending Review to Review in Progress in Pull Requests Dashboard Sep 29, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 30, 2020
@ghost ghost moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Sep 30, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8288 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Oct 9, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Oct 9, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Go to backend, create new product
  2. Fill required field, go to "Create Configurations"
  3. Create New Attribute
  4. Look at the position of the button "Reset" and "Save Attribute"

Before: ✖️ after 1 seconds, the button list re-arranged.

Peek 2020-10-09 13-48

After: ✔️ The position of the button list is correct when loading the "New Attribute" page

Peek 2020-10-09 13-56

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 9, 2020
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Oct 9, 2020
@engcom-Alfa engcom-Alfa moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Oct 9, 2020
@magento-engcom-team magento-engcom-team merged commit 120ca80 into magento:2.4-develop Oct 15, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 15, 2020

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Catalog Event: Global-Contribution-Day Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. tech-partners-contribution Technology Partner: Magestore
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

[Issue] Fix wrong position of button list when load "New Attribute" page
5 participants