Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order Invoice create page doesn't show order items properly for bundle product Fixed Issue #27350 #27602

Merged
merged 5 commits into from
Sep 10, 2020

Conversation

gaurav-473
Copy link
Contributor

@gaurav-473 gaurav-473 commented Apr 4, 2020

Fixed Issue #27350

Fixed Issues (if relevant)

  1. Order Invoice create page doesn't show order items properly for bundle product #27350

While crating invoice for bundle product doesn't show its child items.

Preconditions (*)

  1. Magento version 2.3.4 CE

Steps to reproduce (*)

  1. Create Bundle Product and add 2 items https://prnt.sc/ritlae
  2. Place order for Bundle product with both the items https://prnt.sc/ritmme
  3. Go to create invoice page for the same order https://prnt.sc/ritn0p

Expected result (*)

  1. Order Items should be displayed properly as in screenshot https://prnt.sc/rito2g

Actual result (*)

  1. Items are missing https://prnt.sc/ritn0p

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2020

Hi @gauravagarwal1001. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@gaurav-473
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001. Thank you for your request. I'm working on Magento instance for you

@gaurav-473
Copy link
Contributor Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001, here is your new Magento instance.
Admin access: https://pr-27602.instances.magento-community.engineering/admin_2c29
Login: 6654fd22 Password: 0c2d4c52eae6
Instance will be terminated in up to 3 hours.

@gaurav-473
Copy link
Contributor Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001, here is your Magento instance.
Admin access: https://i-27602-2-4-develop.instances.magento-community.engineering/admin_5322
Login: 959ee0f5 Password: 014f9b1b067b
Instance will be terminated in up to 3 hours.

@ghost ghost added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jun 17, 2020
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gauravagarwal1001, thanks for the pull request! Could you update this PR with the mainline? Also, all the PRs now must have test coverage, it would be nice to add an MFTF to check if the items are displayed.

Let me know if you need any help with this.

Thanks.

@ghost ghost assigned gabrieldagama Aug 11, 2020
Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for contributor's response

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Aug 20, 2020
@ghost ghost assigned sidolov Aug 20, 2020
@engcom-Charlie engcom-Charlie self-assigned this Aug 27, 2020
@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Aug 31, 2020

Hi @gauravagarwal1001, can you please merge the conflict and cover your changes by autotest? Otherwise, we can't proceed with your PR.
Thank you.

@ghost ghost moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Sep 8, 2020
@gabrieldagama
Copy link
Contributor

@magento run Functional Tests B2B

@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-8159 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@gabrieldagama gabrieldagama added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 8, 2020
@engcom-Alfa engcom-Alfa self-assigned this Sep 8, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 8, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Create Bundle Product with different option types (dropdown, radio button, checkbox, multi-select);

2020-09-09_10-21

  1. Create an Order with pre-selected options;
  2. Go to create invoice page for the same order;

Before: ✖️ Items are missing

2020-09-09_10-25

After: ✔️ The bundle product is displayed with a list of options

2020-09-09_10-29

Also, was tested with a few bundle products with different types of options in order, and everything works as expected.

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 9, 2020
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 9, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Sep 10, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 10, 2020
@magento-engcom-team magento-engcom-team merged commit 49c5c47 into magento:2.4-develop Sep 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2020

Hi @gauravagarwal1001, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Community Insider: Cedcommerce community-insider-contribution Component: Bundle Component: Sales Event: Global-Contribution-Day Partner: Cedcommerce partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants