-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup base theme JavaScript modules #27617
Cleanup base theme JavaScript modules #27617
Conversation
Hi @krzksz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Failing B2B test seems to be a false positive (same as in other PRs). |
Hi @ihor-sviziev, thank you for the review. |
@magento give me test instance |
Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you |
Hi @engcom-Delta, here is your new Magento instance. |
@magento create issue |
Hi @krzksz, thank you for your contribution! |
Description (*)
This PR is a part of my effort to improve Magento 2 frontend performance.
Here I went file by file through the network tab and cleaned-up files that are always loaded by a theme. Changes in this PR include:
responsive.js
is completely removed because no code in its contents seems to be valid anymore. Additionally, because it was defined indeps
you couldn't even create a mixin for it.product-info-additional
can't be found anywhere in the code base so lines 23-33 do nothing.mageZoom
andmageGallery
cannot be found in the code as well (maybe a leftover from M1?). There ismage.zoom
widget but it doesn't seem to be imported anywhere..action.toggle.checkout.progress
element doesn't exist in any HTML, PHTML and JS file.checkout-progress-wrapper
does not exist.theme.js
is cleaned-up:collapsiblecreate
event can't be found in the code base.#store
element is not in the code base.ie-class-fixer
is adjusted to be a proper AMD module and usesclassList
API which IE11 supports anyway.Manual testing scenarios (*)
responsive.js
andtheme.js
files nothing should change as code was not applied anyway.ie-class-fixer.js
,ie11
class should be added to the body on IE11.Contribution checklist (*)
Resolved issues: