Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup base theme JavaScript modules #27617

Merged

Conversation

krzksz
Copy link
Contributor

@krzksz krzksz commented Apr 5, 2020

Description (*)

This PR is a part of my effort to improve Magento 2 frontend performance.

Here I went file by file through the network tab and cleaned-up files that are always loaded by a theme. Changes in this PR include:

  • responsive.js is completely removed because no code in its contents seems to be valid anymore. Additionally, because it was defined in deps you couldn't even create a mixin for it.
    1. product-info-additional can't be found anywhere in the code base so lines 23-33 do nothing.
    2. Both mageZoom and mageGallery cannot be found in the code as well (maybe a leftover from M1?). There is mage.zoom widget but it doesn't seem to be imported anywhere.
    3. .action.toggle.checkout.progress element doesn't exist in any HTML, PHTML and JS file.
    4. checkout-progress-wrapper does not exist.
  • theme.js is cleaned-up:
    1. collapsiblecreate event can't be found in the code base.
    2. #store element is not in the code base.
  • ie-class-fixer is adjusted to be a proper AMD module and uses classList API which IE11 supports anyway.

Manual testing scenarios (*)

  1. Regarding responsive.js and theme.js files nothing should change as code was not applied anyway.
  2. Regarding ie-class-fixer.js, ie11 class should be added to the body on IE11.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Cleanup base theme JavaScript modules #28811: Cleanup base theme JavaScript modules

@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2020

Hi @krzksz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@krzksz
Copy link
Contributor Author

krzksz commented Apr 21, 2020

Failing B2B test seems to be a false positive (same as in other PRs).

@ihor-sviziev ihor-sviziev added Cleanup Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Apr 21, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Apr 21, 2020
@ghost ghost assigned ihor-sviziev Apr 21, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7462 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Apr 28, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 28, 2020
@engcom-Delta
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Delta, here is your new Magento instance.
Admin access: https://pr-27617.instances.magento-community.engineering/admin_e9e7
Login: 94d21b1e Password: dce965516612
Instance will be terminated in up to 3 hours.

@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked place order flow, wish list, Compare Products list on responsive and desktop views
Result:
Luma:
PRLuma

Blank:
PRBlank

@engcom-Echo engcom-Echo self-assigned this Apr 28, 2020
@ihor-sviziev ihor-sviziev added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Apr 28, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Apr 28, 2020
@slavvka slavvka added this to the 2.4.1 milestone Apr 28, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. and removed Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Apr 28, 2020
@VladimirZaets VladimirZaets moved this from Merge in Progress to Extended Testing (optional) in Pull Requests Dashboard May 19, 2020
@VladimirZaets VladimirZaets added Progress: accept QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) and removed Progress: extended testing Progress: accept labels May 19, 2020
@engcom-Delta
Copy link
Contributor

@magento create issue

@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 19, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jun 25, 2020
@ghost ghost added the Progress: accept label Jun 25, 2020
@magento-engcom-team magento-engcom-team merged commit 6d06f39 into magento:2.4-develop Jun 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2020

Hi @krzksz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Area: Lib/Frontend Area: Perf/Frontend All tickets related with improving frontend performance. Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Event: Global-Contribution-Day Partner: creativestyle partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

[Issue] Cleanup base theme JavaScript modules
7 participants