Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#27500 - Replace deprecated constructs from OfflinePa… #27627

Merged
merged 4 commits into from
Apr 10, 2020
Merged

magento/magento2#27500 - Replace deprecated constructs from OfflinePa… #27627

merged 4 commits into from
Apr 10, 2020

Conversation

cristiano-pacheco
Copy link
Contributor

…yments PHPUnit.

Magento is slowly moving towards the latest dependencies in the PHP world. Part of this is to have (at least) supported version of PHPUnit ( https://phpunit.de/supported-versions.html )

Description (*)

Updated the tests of Offline_Payments to be compatible with PHPUnit 8.

  1. Unit Tests incompatible with PHPUnit 8 #27500 - app/code/OfflinePayments item.

Manual testing scenarios (*)

 vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/OfflinePayments

@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2020

Hi @cristiano-pacheco. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Apr 5, 2020
lbajsarowicz
lbajsarowicz approved these changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor changes. You can leave as it is, but if you have extra 5 minutes, just review what I suggest.

app/code/Magento/OfflinePayments/Test/Unit/Block/Info/CheckmoTest.php Show resolved Hide resolved
app/code/Magento/OfflinePayments/Test/Unit/Block/Info/CheckmoTest.php Outdated Show resolved Hide resolved
app/code/Magento/OfflinePayments/Test/Unit/Block/Info/CheckmoTest.php Outdated Show resolved Hide resolved
app/code/Magento/OfflinePayments/Test/Unit/Model/CheckmoConfigProviderTest.php Show resolved Hide resolved
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Apr 5, 2020
@ghost ghost assigned lbajsarowicz Apr 5, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7271 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@cristiano-pacheco thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this Apr 8, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 8, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 8, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/OfflinePayments

Before:
Screenshot from 2020-04-08 09-55-54

After:
Screenshot from 2020-04-08 09-53-42

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Apr 8, 2020
@engcom-Echo engcom-Echo self-assigned this Apr 8, 2020
@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Apr 8, 2020
@VladimirZaets VladimirZaets added this to the 2.4.0 milestone Apr 8, 2020
magento-engcom-team pushed a commit that referenced this pull request Apr 10, 2020
@slavvka
ENGCOM-7271: #27500 - Replace deprecated constructs from OfflinePa… #…
ed07e69 
…27627
@magento-engcom-team magento-engcom-team merged commit 625fe59 into magento:2.4-develop Apr 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2020

Hi @cristiano-pacheco, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Apr 10, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request May 1, 2020
Closed
@magento-engcom-team magento-engcom-team removed this from Recently Merged in Pull Requests Dashboard May 6, 2020
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: OfflinePayments Progress: accept Release Line: 2.4
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cristiano-pacheco @magento-engcom-team @engcom-Alfa @engcom-Echo @lbajsarowicz @VladimirZaets