Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Added new actionGroup to click on first row on order grid #27676

Merged
merged 3 commits into from
Apr 14, 2020
Merged

[MFTF] Added new actionGroup to click on first row on order grid #27676

merged 3 commits into from
Apr 14, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Apr 9, 2020

Description (*)

Added AdminClickFirstRowOrderGridActionGroup for clicking on first row on order grid

@m2-assistant
Copy link

m2-assistant bot commented Apr 9, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Apr 9, 2020
@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 9, 2020
@rogyar rogyar self-assigned this Apr 9, 2020
@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Apr 9, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Apr 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7293 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Apr 10, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 10, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Apr 10, 2020
@engcom-Echo engcom-Echo self-assigned this Apr 10, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Apr 10, 2020
@elevinskii
Copy link
Member

That's good changes are giving us opportunity to write only 1 line of XML code instead 2 ones, making our code more understandable and readable - it's out of doubts.

But I'd suggest to go a bit more further - as our admin grids are very similar (more or less), we could put new action group inside Ui module and use it without any relation to particular page (but then AdminOrdersGridSection.firstRow should be replaced by AdminDataGridTableSection.firstRow, probably).

@Usik2203
Let me know, if you need more details. Thanks!

@VladimirZaets VladimirZaets added this to the 2.4.0 milestone Apr 10, 2020
@lbajsarowicz
Copy link
Contributor

I know that's minor issue, but would you be able to change it to AdminOrderGridClickFirstRowActionGroup? I find it easier to find the Action Groups related to some area entering in PHPStorm Admin + area + do something and not always it's showing the right entries : )

Imagine that when you enter AdminOrderGrid you have all actions related one by another.

lbajsarowicz
lbajsarowicz approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Awesome, thank you

@ghost ghost moved this from Merge in Progress to Ready for Testing in Pull Requests Dashboard Apr 10, 2020
@ghost ghost assigned lbajsarowicz Apr 10, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7293 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 13, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Apr 13, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Apr 13, 2020
magento-engcom-team pushed a commit that referenced this pull request Apr 14, 2020
@slavvka
ENGCOM-7293: [MFTF] Added new actionGroup to click on first row on or…
442a354 
…der grid #27676
@magento-engcom-team magento-engcom-team merged commit b844f5f into magento:2.4-develop Apr 14, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 14, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Apr 14, 2020
@magento-engcom-team magento-engcom-team removed this from Recently Merged in Pull Requests Dashboard May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@rogyar rogyar rogyar approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Backend Component: Bundle Component: Catalog Component: CatalogInventory Component: Checkout Component: ConfigurableProduct Component: Fedex Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Usik2203 @magento-engcom-team @engcom-Alfa @elevinskii @lbajsarowicz @rogyar @VladimirZaets @engcom-Echo @slavvka