Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Using action group to go to admin category page #27689

Merged
merged 2 commits into from
Apr 16, 2020
Merged

[MFTF] Using action group to go to admin category page #27689

merged 2 commits into from
Apr 16, 2020

Conversation

Usik2203
Copy link
Contributor

Description (*)

This PR using AdminOpenCategoryPageActionGroup to go to admin category page.
And changes this part of code
<amOnPage url="{{AdminCategoryPage.url}}" stepKey="goToCategoryPage"/>
<waitForPageLoad stepKey="waitForCategoryPageLoad"/>

@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Apr 10, 2020
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 10, 2020
@rogyar rogyar self-assigned this Apr 10, 2020
rogyar
rogyar requested changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the failing tests most likely there's an issue on the test generation step. Usually, it happens when there's some error like missing action group or so.

Could you, please, run the functional tests locally and make sure that you have no errors?

Thank you!

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Apr 10, 2020
@Usik2203
Copy link
Contributor Author

Hi @rogyar .
I have fixed failed checks related with my changes.
Errors in Functional Tests CE not related with my changes.

Thanks you!

lbajsarowicz
lbajsarowicz approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 That is really nice of you that you decided to replace these Actions into ActionGroups. Thank you!

@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Apr 10, 2020
@ghost ghost assigned lbajsarowicz Apr 10, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7303 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Apr 14, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 14, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 14, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Apr 14, 2020
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests CE

@engcom-Echo engcom-Echo self-assigned this Apr 14, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Apr 15, 2020
@VladimirZaets VladimirZaets added this to the 2.4.0 milestone Apr 15, 2020
magento-engcom-team pushed a commit that referenced this pull request Apr 16, 2020
@slavvka
ENGCOM-7303: [MFTF] Using action group to go to admin category page #…
ffbab87 
…27689
@magento-engcom-team magento-engcom-team merged commit b9f6488 into magento:2.4-develop Apr 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Apr 16, 2020
@magento-engcom-team magento-engcom-team removed this from Recently Merged in Pull Requests Dashboard May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar requested changes

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Bundle Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Usik2203 @magento-engcom-team @engcom-Alfa @engcom-Echo @lbajsarowicz @rogyar @VladimirZaets