Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Use ActionGroup to open products grid page #27697

Merged
merged 13 commits into from
Jul 16, 2020
Merged

[MFTF] Use ActionGroup to open products grid page #27697

merged 13 commits into from
Jul 16, 2020

Conversation

Usik2203
Copy link
Contributor

Description (*)

This PR uses AdminOpenProductIndexPageActionGroup to go to catalog products grid and removes this part of code
<amOnPage url="{{AdminProductIndexPage.url}}" stepKey="visitAdminProductPageBundle"/>
<waitForPageLoad stepKey="waitForProductPageLoadBundle"/>

@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Apr 10, 2020
@magento-engcom-team magento-engcom-team added Component: Bundle Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 10, 2020
lbajsarowicz
lbajsarowicz previously approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Thank you for your effort to improve MFTF Tests! Really appreciate that!

@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Apr 10, 2020
@ghost ghost assigned lbajsarowicz Apr 10, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7304 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Apr 15, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 15, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 15, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Apr 15, 2020
@engcom-Echo engcom-Echo self-assigned this Apr 15, 2020
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Apr 16, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7304 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Jul 3, 2020
@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 3, 2020
@engcom-Delta engcom-Delta moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jul 3, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jul 3, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 6, 2020
@slavvka
Copy link
Member

slavvka commented Jul 7, 2020

@magento run WebAPI tests

@slavvka
Copy link
Member

slavvka commented Jul 7, 2020

@magento run WebAPI Tests

@slavvka
Copy link
Member

slavvka commented Jul 13, 2020

@magento run Integration Tests

@Usik2203
Copy link
Contributor Author

@magento run all tests

@Usik2203
Copy link
Contributor Author

@magento run all tests

@slavvka
Copy link
Member

slavvka commented Jul 15, 2020

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Jul 16, 2020
@slavvka
ENGCOM-7304: [MFTF] Use ActionGroup to open products grid page #27697
fda3859
@magento-engcom-team magento-engcom-team merged commit e89ef20 into magento:2.4-develop Jul 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavvka slavvka slavvka requested changes

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@slavvka slavvka

@engcom-Alfa engcom-Alfa

@engcom-Delta engcom-Delta

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Bundle Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Usik2203 @magento-engcom-team @engcom-Alfa @engcom-Echo @slavvka @lbajsarowicz @VladimirZaets @engcom-Delta @lenaorobei