Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored code #27758

Merged
merged 6 commits into from
Aug 14, 2020
Merged

refactored code #27758

merged 6 commits into from
Aug 14, 2020

Conversation

ProkopovVitaliy
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. StockState.php Are theses comment a feature or a forget ? #26702: Issue title
    StockState.php Are theses comment a feature or a forget ?

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2020

Hi @ProkopovVitaliy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Apr 11, 2020
@rogyar rogyar self-assigned this Apr 11, 2020
@ghost ghost added Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. labels Aug 7, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Aug 7, 2020
@ghost ghost assigned VladimirZaets Aug 7, 2020
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-7979 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7979 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Aug 12, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Aug 12, 2020
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Aug 12, 2020 •
edited
Loading

✔️ QA Passed

The stock functionality still works as previously (expected).

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Aug 12, 2020
@engcom-Charlie engcom-Charlie self-assigned this Aug 12, 2020
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Aug 12, 2020
@slavvka
Copy link
Member

slavvka commented Aug 13, 2020

@magento run all tests

@magento-engcom-team magento-engcom-team mentioned this pull request Aug 14, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Aug 14, 2020
@slavvka
ENGCOM-7979: refactored code #27758
07558aa
@magento-engcom-team magento-engcom-team merged commit f7e4b2a into magento:2.4-develop Aug 14, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 14, 2020

Hi @ProkopovVitaliy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@rogyar rogyar

@VladimirZaets VladimirZaets

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: CatalogInventory Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ProkopovVitaliy @magento-engcom-team @engcom-Alfa @slavvka @rogyar @VladimirZaets @engcom-Charlie