-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent product gallery elements from blinking when they load #27871
Prevent product gallery elements from blinking when they load #27871
Conversation
Hi @krzksz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @krzksz,
Your changes looks good to me!
Could you review unit & static test failures and update your PR?
All tests green 💚 |
Hi @ptylek, thank you for the review.
|
@krzksz do you think this change could have some additional tests? it seems to be improvement rather than gallery functionality change and all current tests have passed. |
I think it is impossible to cover this change with anything automatic. There are already some unit tests which failed previously and I had to adjust them so the implementation is untouched. |
@magento create issue |
@magento run all tests |
… fix-blinking-gallery
@magento run all tests |
Failed functional tests not related to the changes in this PR |
@magento run all tests |
Hi @krzksz, thank you for your contribution! |
Description (*)
In this PR I would like to improve the loading experience of the gallery on product page. On the attached screenshot you can see that there are small periods of time when:
Before:
After:
Note: There is a loader shown properly for a few frames, it just didn't get captured on the gif.
Manual testing scenarios (*)
Contribution checklist (*)
Resolved issues: