Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compliance to StorefrontMinicartSection #27955

Merged
merged 2 commits into from
Apr 29, 2020
Merged

compliance to StorefrontMinicartSection #27955

merged 2 commits into from
Apr 29, 2020

Conversation

engcom-Echo
Copy link
Contributor

Description (*)

The tests are consistent with StorefrontMinicartSection. StorefrontMiniCartSection removed.

Related Pull Requests

Fixed Issues (if relevant)

  1. MFTF: Inconsistent case in Section name #27897 : MFTF: Inconsistent case in Section name MFTF: Inconsistent case in Section name #27897

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2020

Hi @engcom-Echo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Apr 23, 2020
@engcom-Echo
Copy link
Contributor Author

@magento run all tests

@rogyar rogyar self-assigned this Apr 24, 2020
@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Apr 24, 2020
@rogyar
Copy link
Contributor

rogyar commented Apr 24, 2020

The failing test is not related to the current change

@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Apr 24, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7485 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Apr 24, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Extended Testing (optional) in Pull Requests Dashboard Apr 24, 2020
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Kilo engcom-Kilo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Apr 28, 2020
@slavvka slavvka added this to the 2.4.0 milestone Apr 28, 2020
@slavvka slavvka linked an issue Apr 28, 2020 that may be closed by this pull request
MFTF: Inconsistent case in Section name #27897
Closed
magento-engcom-team pushed a commit that referenced this pull request Apr 29, 2020
@slavvka
ENGCOM-7485: compliance to StorefrontMinicartSection #27955
3ff32ab
@magento-engcom-team magento-engcom-team merged commit 1aebbb7 into magento:2.4-develop Apr 29, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2020

Hi @engcom-Echo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Apr 29, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request May 1, 2020
Closed
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Kilo engcom-Kilo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Catalog Component: CatalogRule Component: Checkout Component: Quote Component: Translation Progress: accept Release Line: 2.4
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

MFTF: Inconsistent case in Section name
6 participants
@engcom-Echo @rogyar @magento-engcom-team @engcom-Alfa @engcom-Kilo @slavvka