Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate AbstractAction and it's public methods #27964

Merged
merged 5 commits into from
Apr 29, 2020
Merged

Deprecate AbstractAction and it's public methods #27964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1759898
Add deprecation to AbstractAction, deprecate methods that should neve…
lbajsarowicz Apr 24, 2020
075d377
Fix too much rolled back
lbajsarowicz Apr 24, 2020
f5a013e
Remove links from annotations
lbajsarowicz Apr 24, 2020
90b3785
Fix annotation
lenaorobei Apr 24, 2020
d857b89
Update annotation
lenaorobei Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/internal/Magento/Framework/App/Action/AbstractAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<?php
/**
* Abstract redirect/forward action class
*
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
Expand All @@ -10,6 +8,12 @@
use Magento\Framework\App\RequestInterface;
use Magento\Framework\App\ResponseInterface;

/**
* Abstract redirect/forward action class
*
* @deprecated Inheritance in controllers should be avoided in favor of composition
* @see \Magento\Framework\App\ActionInterface
*/
abstract class AbstractAction implements \Magento\Framework\App\ActionInterface
{
/**
Expand Down
3 changes: 2 additions & 1 deletion lib/internal/Magento/Framework/App/Action/Action.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
* It contains standard action behavior (event dispatching, flag checks)
* Action classes that do not extend from this class will lose this behavior and might not function correctly
*
* @deprecated Use \Magento\Framework\App\ActionInterface
* @deprecated Inheritance in controllers should be avoided in favor of composition
* @see \Magento\Framework\App\ActionInterface
*
* phpcs:disable Magento2.Classes.AbstractApi
* @api
Expand Down