Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StorefrontLoginWithIncorrectCredentialsTest refactored #28039

Merged
merged 2 commits into from
May 21, 2020
Merged

StorefrontLoginWithIncorrectCredentialsTest refactored #28039

merged 2 commits into from
May 21, 2020

Conversation

ajithkumar-maragathavel
Copy link
Contributor

Description (*)

StorefrontLoginWithIncorrectCredentialsTest is refactored according to the best practices followed by MFTF.

Manual testing scenarios (*)

  1. Run the StorefrontLoginWithIncorrectCredentialsTest in the local environment and verified the test runs successfully.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2020

Hi @ajithkumar-maragathavel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Apr 29, 2020
@ajithkumar-maragathavel
Copy link
Contributor Author

@rogyar Please review it.

@rogyar rogyar self-assigned this May 4, 2020
@rogyar rogyar added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: MFTF test coverage labels May 4, 2020
@rogyar
Copy link
Contributor

rogyar commented May 4, 2020

Hi @ajithkumar-maragathavel. Great job!

rogyar
rogyar approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests are not related to the current change

@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard May 4, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7509 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this May 5, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard May 5, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard May 5, 2020
@engcom-Echo engcom-Echo self-assigned this May 5, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard May 5, 2020
@slavvka slavvka added this to the 2.4.1 milestone May 5, 2020
slavvka added a commit that referenced this pull request May 21, 2020
@slavvka
ENGCOM-7509: StorefrontLoginWithIncorrectCredentialsTest refactored #…
3c5e3ca 
…28039
@slavvka slavvka merged commit cda0b90 into magento:2.4-develop May 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 21, 2020

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard May 21, 2020
@slavvka
Copy link
Member

slavvka commented May 21, 2020

@magento create issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: MFTF test coverage Component: Customer Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ajithkumar-maragathavel @rogyar @magento-engcom-team @engcom-Alfa @slavvka @engcom-Echo