Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue button used action-primary class changed color if click outside #28083

Merged

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented May 2, 2020

Description (*)

Continue works by @neerajchand after long inactivity in PR 27560
update with correction in code style base magento standards

Related Pull Requests

Fixed Issues (if relevant)

  1. fixes In Floating cart delete pop-up, When user click on out side of OK button than button color is changed. #27095: In Floating cart delete pop-up, In Floating cart delete pop-up, When user click

Manual testing scenarios (*)

  1. Magento 2.3.4+
  2. Theme luma
  3. Add any products to cart
  4. Remove product added
  5. Click outside of modal confirm remove

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 2, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard May 2, 2020
@mrtuvn mrtuvn changed the title Fix issue button used action-primary class changed color if click Fix issue button used action-primary class changed color if click outside May 2, 2020
@edenduong edenduong self-assigned this May 4, 2020
@edenduong
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-28083.instances.magento-community.engineering/admin_3c9c
Login: 77939bf5 Password: cf97839cf64e
Instance will be terminated in up to 3 hours.

Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mrtuvn :

Could you please solve this issue? I see it has small white color at the OK button when click outside

image

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard May 4, 2020
@mrtuvn
Copy link
Contributor Author

mrtuvn commented May 4, 2020

Hi @mrtuvn :

Could you please solve this issue? I see it has small white color at the OK button when click outside

image

i think this is default of magento ! Do you meaning the white small bar in the top and bottom of button Ok ? It's is box-shadow applied to button

@edenduong
Copy link
Contributor

Hi @mrtuvn :

Please see:
Before:
image

After click out side:

image

@edenduong edenduong added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels May 4, 2020
@magento-engcom-team
Copy link
Contributor

Hi @edenduong, thank you for the review.
ENGCOM-7510 has been created to process this Pull Request

@ghost ghost assigned ptylek May 5, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-7510 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this May 6, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard May 6, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Magento 2.4-develop (Luma theme)

Manual testing scenario:

  1. Add any products to the cart;
  2. Click on remove button in mini-cart;
  3. Click outside of modal confirm remove;

Before: ✖️

Peek 2020-05-06 14-36

After: ✔️

Peek 2020-05-06 14-45

The same results and with the Blank theme

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard May 6, 2020
@engcom-Charlie engcom-Charlie self-assigned this May 6, 2020
@engcom-Charlie
Copy link
Contributor

The failing functional tests are not related to the change in this pr.

@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard May 7, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels May 7, 2020
@slavvka slavvka added this to the 2.4.1 milestone May 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 21, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard May 21, 2020
@sdzhepa sdzhepa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label May 22, 2020
@mrtuvn mrtuvn deleted the fix-issue-27095-button-primary-color branch June 7, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

In Floating cart delete pop-up, When user click on out side of OK button than button color is changed.
8 participants