-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue button used action-primary class changed color if click outside #28083
Fix issue button used action-primary class changed color if click outside #28083
Conversation
Hi @mrtuvn. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me test instance |
Hi @edenduong. Thank you for your request. I'm working on Magento instance for you |
Hi @edenduong, here is your new Magento instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mrtuvn :
Could you please solve this issue? I see it has small white color at the OK button when click outside
i think this is default of magento ! Do you meaning the white small bar in the top and bottom of button Ok ? It's is box-shadow applied to button |
Hi @mrtuvn : After click out side: |
Hi @edenduong, thank you for the review. |
Hi @ptylek, thank you for the review. |
The failing functional tests are not related to the change in this pr. |
Hi @mrtuvn, thank you for your contribution! |
Description (*)
Continue works by @neerajchand after long inactivity in PR 27560
update with correction in code style base magento standards
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)