Issue #27925, moved the submit button to the inside of the <form>

[vestman]

Description (*)

Placing the submit button inside the <form id="purchaseorder-form"...></form> makes implicit submission[1] possible without altering any JS.
[1] - https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#implicit-submission

Related Pull Requests

https://github.com/magento/partners-magento2b2b/pull/417

Fixed Issues (if relevant)

1. Fixes Checkout: Placing an order using the enter key causes a redirect to the checkout #27925: Checkout: Placing an order using the enter key causes a redirect to the checkout

Manual testing scenarios (*)

1. Add a product to the cart and proceed to the checkout
2. Enter your shipping details and proceed to "Review & Payments"
3. Select "Purchase Order" as your payment of choice
4. Enter a random "Purchase Order Number"
5. Press enter while the focus is still on the "Purchase Order Numer" field

Expected result

The form should be submitted (and validated) on keyboard Enter. Order is placed.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @vestman. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[vestman]

@magento give me test instance

[magento-engcom-team]

Hi @vestman. Thank you for your request. I'm working on Magento instance for you

[dmytro-ch]

Hello @vestman, thank you for your contribution. Due to Magento Definition of Done the changes should be covered by tests. Could you please cover your fix by an automated test? I think in this particular case the Functional test is preferable.
Thank you!

[engcom-Kilo]

Working on MFTF test

[engcom-Kilo]

Added MFTF tests.

[engcom-Kilo]

@magento run all tests

[vestman]

@magento run all tests

[engcom-Kilo]

@magento run all tests

[engcom-Alfa]

✔️ QA Passed

Precondition:

Enable "Purchase Order" as a payment method

Manual testing scenario:

1. Add a product to the cart and proceed to the checkout
2. Enter your shipping details and proceed to "Review & Payments"
3. Select "Purchase Order" as your payment of choice
4. Enter a random "Purchase Order Number"
5. Press enter while the focus is still on the "Purchase Order Numer" field

After: ✔️ The form is submitted on the Enter keyboard and the order is placed

[magento-engcom-team]

Hi @gabrieldagama, thank you for the review.
ENGCOM-8091 has been created to process this Pull Request

[ihor-sviziev]

@gabrieldagama seems like now we have incorrect status

[m2-assistant]

Hi @vestman, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.