Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixed] - resolve issue with filter visibility with column visibility in grid #28385

Merged
merged 5 commits into from
Oct 6, 2020
Merged

[Fixed] - resolve issue with filter visibility with column visibility in grid #28385

merged 5 commits into from
Oct 6, 2020

Conversation

niravkrish
Copy link
Contributor

@niravkrish niravkrish commented May 27, 2020 •
edited by m2-assistant bot
Loading

Description (*)

I found one common issue which is available with most of the grid was Filter visibility does not work with column visibility.
So I have debugged and Found this solution.
I have checked and changed almost all relevant grid.

I found and applied this changes for the below files.

app/code/Magento/Search/view/adminhtml/ui_component/search_synonyms_grid.xml
app/code/Magento/GroupedProduct/view/adminhtml/ui_component/grouped_product_listing.xml
app/code/Magento/Bundle/view/adminhtml/ui_component/bundle_product_listing.xml
app/code/Magento/Sales/view/adminhtml/ui_component/sales_order_invoice_grid.xml
app/code/Magento/Sales/view/adminhtml/ui_component/sales_order_view_invoice_grid.xml
app/code/Magento/Sales/view/adminhtml/ui_component/sales_order_creditmemo_grid.xml
app/code/Magento/Sales/view/adminhtml/ui_component/sales_order_view_creditmemo_grid.xml
app/code/Magento/Sales/view/adminhtml/ui_component/sales_order_shipment_grid.xml
app/code/Magento/Sales/view/adminhtml/ui_component/sales_order_grid.xml
app/code/Magento/Sales/view/adminhtml/ui_component/sales_order_view_shipment_grid.xml
app/code/Magento/Cms/view/adminhtml/ui_component/cms_page_listing.xml
app/code/Magento/Cms/view/adminhtml/ui_component/cms_block_listing.xml
app/code/Magento/ConfigurableProduct/view/adminhtml/ui_component/configurable_associated_product_listing.xml

Expected Result

  • Filter visibility should be toggle with column visibility as the same for all columns.

Actual Result

  • On Admin Sales Order grid purchase point filter visibility does not toggle with purchase point column visibility.

ezgif com-optimize

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] [Fixed] - resolve issue with filter visibility with column visibility in grid #30345: [Fixed] - resolve issue with filter visibility with column visibility in grid

@m2-assistant
Copy link

m2-assistant bot commented May 27, 2020

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard May 27, 2020
@niravkrish
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @niravkrish. Thank you for your request. I'm working on Magento instance for you

@niravkrish niravkrish force-pushed the fixed-filter-visibility-toggle branch from 47ef5b7 to 0a0c8e4 Compare June 1, 2020 15:51
@niravkrish
Copy link
Contributor Author

@magento run all tests

@niravkrish
Copy link
Contributor Author

@magento run Functional Tests CE
@magento run Functional Tests EE
@magento run Functional Tests B2B

@niravkrish
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @niravkrish. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @niravkrish, here is your new Magento instance.
Admin access: https://pr-28385.instances.magento-community.engineering/admin_2e30
Login: 4110fac9 Password: 535307138d0a
Instance will be terminated in up to 3 hours.

@VladimirZaets VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 18, 2020
@sidolov
Copy link
Contributor

sidolov commented Sep 14, 2020

@magento run all tests

sidolov
sidolov previously approved these changes Sep 14, 2020
View reviewed changes
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Sep 14, 2020
@ghost ghost assigned sidolov Sep 14, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo engcom-Echo moved this from Changes Requested to Pending Review in Pull Requests Dashboard Sep 28, 2020
@sidolov sidolov moved this from Pending Review to Review in Progress in Pull Requests Dashboard Oct 1, 2020
@ghost ghost moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Oct 1, 2020
@sidolov sidolov added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Oct 1, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8211 has been created to process this Pull Request

@engcom-Echo engcom-Echo removed their assignment Oct 2, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Oct 5, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Result:
Filter visibility is toggled with column visibility as the same for all columns.
Peek 2020-09-23 15-13

@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Oct 5, 2020
Closed
@engcom-Delta engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 5, 2020
@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

@engcom-Delta engcom-Delta moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Oct 5, 2020
magento-engcom-team pushed a commit that referenced this pull request Oct 6, 2020
@sidolov
ENGCOM-8211: [Fixed] - resolve issue with filter visibility with colu…
814639b 
…mn visibility in grid #28385
@magento-engcom-team magento-engcom-team merged commit 2538135 into magento:2.4-develop Oct 6, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 6, 2020

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Delta engcom-Delta engcom-Delta requested changes

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

@engcom-Delta engcom-Delta

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Bundle Component: Cms Component: ConfigurableProduct Component: GroupedProduct Component: Sales Component: Search Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [Fixed] - resolve issue with filter visibility with column visibility in grid
7 participants
@niravkrish @magento-engcom-team @sidolov @engcom-Alfa @engcom-Echo @engcom-Delta @VladimirZaets