Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring create product with several websites and check url rewrites test #28391

Merged
merged 4 commits into from
Jun 5, 2020
Merged

Refactoring create product with several websites and check url rewrites test #28391

merged 4 commits into from
Jun 5, 2020

Conversation

kate-kyzyma
Copy link
Contributor

Description (*)

AdminCreateProductWithSeveralWebsitesAndCheckURLRewritesTest is refactored according to the best practices followed by MFTF.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Run the StorefrontLoginWithIncorrectCredentialsTest in the local environment and verified the test runs successfully.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 27, 2020

Hi @kate-kyzyma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard May 27, 2020
@magento-engcom-team magento-engcom-team added Component: Catalog Component: UrlRewrite Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 27, 2020
@dmytro-ch dmytro-ch self-assigned this May 27, 2020
@dmytro-ch
Copy link
Contributor

@magento run all tests

dmytro-ch
dmytro-ch requested changes May 28, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kate-kyzyma, well done! The overall result looks good to me.
Could you please apply minor improvements?
Thank you!

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminSubmitCategoriesPopupActionGroup.xml Outdated Show resolved Hide resolved
...ento/UrlRewrite/Test/Mftf/ActionGroup/AssertAdminStoreValueIsSetForUrlRewriteActionGroup.xml Outdated Show resolved Hide resolved
...ento/UrlRewrite/Test/Mftf/ActionGroup/AssertAdminStoreValueIsSetForUrlRewriteActionGroup.xml Outdated Show resolved Hide resolved
@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard May 28, 2020
@dmytro-ch
Copy link
Contributor

@magento run all tests

1 similar comment
@dmytro-ch
Copy link
Contributor

@magento run all tests

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 2, 2020
@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Jun 2, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7606 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jun 3, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jun 3, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Echo engcom-Echo self-assigned this Jun 3, 2020
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jun 3, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jun 4, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 4, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jun 4, 2020
magento-engcom-team pushed a commit that referenced this pull request Jun 5, 2020
@slavvka
ENGCOM-7606: Refactoring create product with several websites and che…
b60e727 
…ck url rewrites test #28391
@magento-engcom-team magento-engcom-team merged commit 8df804d into magento:2.4-develop Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @kate-kyzyma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jun 5, 2020
@kate-kyzyma kate-kyzyma deleted the Refactoring-CreateProductWithSeveralWebsitesAndCheckURLRewritesTest branch June 24, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Component: UrlRewrite Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kate-kyzyma @dmytro-ch @magento-engcom-team @engcom-Alfa @slavvka @engcom-Echo