Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when creating a store view if there are CMS pages with the same URL key #28421

Merged
merged 3 commits into from
Jun 24, 2020

Conversation

engcom-Charlie
Copy link
Contributor

Description (*)

Fixed issue and covered by test.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Error when creating a store view if there are CMS pages with the same URL key #28357

Manual testing scenarios (*)

See #28357

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 29, 2020

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this May 29, 2020
@ghost ghost added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Jun 1, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage labels Jun 1, 2020
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Jun 1, 2020

Looks like false positives, but let's restart tests again

@magento run Functional Tests B2B, Functional Tests EE

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved

Failing functional tests looks not related to changes from this PR.

@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jun 1, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7602 has been created to process this Pull Request

@ghost ghost added the Priority: P3 May be fixed according to the position in the backlog. label Jun 1, 2020
@engcom-Alfa engcom-Alfa self-assigned this Jun 2, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jun 2, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Navigate to Admin Panel > Stores > All Stores and create 2 store views:
Name: German
Code: german
Status: Enabled
Name: French
Code: french
Status: Enabled
  1. Navigate to Admin Panel > Content > Pages and create 2 pages:
Page Title: About Us
URL Key: about-us
Store View: French
Page Title: About Us
URL Key: about-us
Store View: German
  1. Navigate to Admin Panel > Stores > All Stores and create store view
Name: Spanish
Code: spanish
Status: Enabled
  1. Save the store view;

Before: ✖️ Error message "Something went wrong while saving. Please review the error log."

Screenshot from 2020-06-02 11-27-34
Screenshot from 2020-06-02 11-29-28

After: ✔️ Store view created successfully.

Screenshot from 2020-06-02 11-52-21

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jun 2, 2020
@engcom-Echo engcom-Echo self-assigned this Jun 2, 2020
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 2, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jun 2, 2020
… 28357

� Conflicts:
�	dev/tests/integration/testsuite/Magento/CmsUrlRewrite/Plugin/Cms/Model/Store/ViewTest.php
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 19, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jun 19, 2020
magento-engcom-team pushed a commit that referenced this pull request Jun 24, 2020
@magento-engcom-team magento-engcom-team merged commit ba3424e into magento:2.4-develop Jun 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 24, 2020

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: CmsUrlRewrite Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

Error when creating a store view if there are CMS pages with the same URL key
6 participants