Fix duplicate css when enable critical path

[mrtuvn]

Description (*)

This PR continue great works #27211 by @krzksz in latest codebase
This PR aim to bring patch fix issue css show twice. Before the fix magento place redundant link style at bottom of page before body close end

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes CSS shows up twice when Critical CSS Enabled #26498

Manual testing scenarios (*)

1. Enable critical path css
2. Run deploy static content + clean cache
3. Go to homepage inspect in browser element "page-wrapper"
4. We will see 2 file styles-l.css have style apply for that element

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[mrtuvn]

@magento run all tests

[ihor-sviziev]

@mrtuvn does this PR replace #27211 or what is the purpose of it?

[ihor-sviziev]

@magento run all tests

[mrtuvn]

@ihor-sviziev just continue works by @krzksz after long inactive
If @krzksz continue i will close mine PR

[mrtuvn]

@magento run all tests

[ihor-sviziev]

Hi @mrtuvn,
In general your changes looks good, but I have few suggestions, please review them

[ihor-sviziev]

@mrtuvn Could you also squash your changes into one or few commits in order not to have 13 merge commits?

[mrtuvn]

@ihor-sviziev i have squashed commits and repick all to one commit. Ready for review and test

[ihor-sviziev]

@magento run all tests

[mrtuvn]

@magento run Static Tests

[mrtuvn]

@magento run Database Compare, Functional Tests CE, Functional Tests EE, Functional Tests B2B, Integration Tests, Magento Health Index, Sample Data Tests CE, Sample Data Tests EE, Sample Data Tests B2B, Unit Tests, WebAPI Tests

[ihor-sviziev]

@magento run Semantic Version Checker, Database Compare

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7678 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Enable critical path CSS ( Admin -> Stores -> Configuration -> Advanced -> Developer -> Css Settings, set Use CSS critical path to Yes);
2. Run deploy static content + clean cache;
3. Go to homepage inspect in browser element "page-wrapper"

Before: ✖️ styles-m.css and styles-l.css styles show up multiple times in developer tools.

After: ✔️ The stylesheets are only loaded once

✔️ all external stylesheets are located in the same order at the end of , after inline critical CSS

Also was tested on the Blank theme and with sample data.

[m2-assistant]

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[xanka]

Hi @mrtuvn Did you test on production mode?

[mrtuvn]

What problem with production that you got? This patch only available in 2.4-develop branch