Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#28481: GraphQl. updateCustomer allows to set any INT value in gender argument #28487

Merged
merged 4 commits into from
Jun 27, 2020
Merged

magento/magento2#28481: GraphQl. updateCustomer allows to set any INT value in gender argument #28487

merged 4 commits into from
Jun 27, 2020

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Jun 3, 2020 •
edited
Loading

Description (*)

PR fixes GraphQl. updateCustomer allows to set any INT value in gender argument

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento#228481: GraphQl. updateCustomer allows to set any INT value in gender argument

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 3, 2020

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jun 3, 2020
@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 3, 2020
@dmytro-ch dmytro-ch self-assigned this Jun 3, 2020
@atwixfirster
Copy link
Contributor Author

@magento run all tests

@atwixfirster
Copy link
Contributor Author

@magento run Database Compare

@atwixfirster
Copy link
Contributor Author

@magento run Static Tests,Unit Tests,WebAPI Tests,Integration Tests

@atwixfirster
Copy link
Contributor Author

@magento run Static Tests,Unit Tests,WebAPI Tests,Integration Tests

@atwixfirster
Copy link
Contributor Author

@magento run Static Tests

@dmytro-ch
Copy link
Contributor

@magento run all tests

dmytro-ch
dmytro-ch requested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @atwixfirster, could you please update your working branch and resolve merge conflicts?

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Jun 10, 2020
@atwixfirster
Merge remote-tracking branch 'origin/2.4-develop' into issue-28481-up…
f384190 
…dateCustomer

# Conflicts:
#	dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/UpdateCustomerTest.php
@atwixfirster
Copy link
Contributor Author

@magento run all tests

@nrkapoor nrkapoor requested a review from avattam06 June 11, 2020 12:59
@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 11, 2020
@ghost ghost assigned prabhuram93 Jun 17, 2020
dthampy
dthampy reviewed Jun 26, 2020
View reviewed changes
app/code/Magento/CustomerGraphQl/Model/Customer/ValidateCustomerData.php Outdated
/**
* @var ValidateCustomerDataInterface[]
*/
protected $validators = [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the variable to private.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanations, @dthampy !

done

@ghost ghost assigned dthampy Jun 26, 2020
@dthampy dthampy moved this from Merge in Progress to Changes Requested in Pull Requests Dashboard Jun 26, 2020
@ghost ghost moved this from Changes Requested to Merge in Progress in Pull Requests Dashboard Jun 26, 2020
@dthampy
Copy link
Contributor

dthampy commented Jun 26, 2020 •
edited
Loading

@atwixfirster, Magento Health Index build was failing. I left a comment in the appropriate file. If you could take care of that and run all the magento tests, I think we should be good. We can then proceed with Merge.

@dthampy dthampy moved this from Merge in Progress to Changes Requested in Pull Requests Dashboard Jun 26, 2020
@ghost ghost moved this from Changes Requested to Merge in Progress in Pull Requests Dashboard Jun 26, 2020
@dthampy dthampy moved this from Merge in Progress to Changes Requested in Pull Requests Dashboard Jun 26, 2020
@ghost ghost moved this from Changes Requested to Merge in Progress in Pull Requests Dashboard Jun 26, 2020
@avattam06
Copy link
Contributor

@magento run all tests

@atwixfirster
Copy link
Contributor Author

@magento run all tests

@ghost ghost moved this from Merge in Progress to Ready for Testing in Pull Requests Dashboard Jun 26, 2020
@dthampy dthampy moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jun 26, 2020
@dthampy dthampy moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Jun 26, 2020
magento-engcom-team pushed a commit that referenced this pull request Jun 27, 2020
@cpartica
ENGCOM-7750: #28481: GraphQl. updateCustomer allows to set any INT va…
5d615b2 
…lue in gender argument #28487
@magento-engcom-team magento-engcom-team merged commit 5843c0b into magento:2.4-develop Jun 27, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 27, 2020

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch requested changes

@dthampy dthampy dthampy approved these changes

@prabhuram93 prabhuram93 prabhuram93 approved these changes

@avattam06 avattam06 Awaiting requested review from avattam06

Assignees

@dmytro-ch dmytro-ch

@dthampy dthampy

@prabhuram93 prabhuram93

Labels
Component: CustomerGraphQl Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Project: GraphQL Release Line: 2.4
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

GraphQl. updateCustomer allows to set any INT value in gender argument
8 participants
@atwixfirster @dmytro-ch @dthampy @avattam06 @prabhuram93 @nrkapoor @magento-engcom-team @cpartica