-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magento/magento2#28481: GraphQl. updateCustomer allows to set any INT value in gender argument #28487
magento/magento2#28481: GraphQl. updateCustomer allows to set any INT value in gender argument #28487
Conversation
Hi @atwixfirster. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
1ffde8a
to
267dba4
Compare
@magento run Database Compare |
@magento run Static Tests,Unit Tests,WebAPI Tests,Integration Tests |
267dba4
to
895b1af
Compare
@magento run Static Tests,Unit Tests,WebAPI Tests,Integration Tests |
895b1af
to
e5e50e7
Compare
@magento run Static Tests |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @atwixfirster, could you please update your working branch and resolve merge conflicts?
…dateCustomer # Conflicts: # dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/UpdateCustomerTest.php
@magento run all tests |
app/code/Magento/CustomerGraphQl/Model/Customer/ValidateCustomerData.php
Outdated
Show resolved
Hide resolved
app/code/Magento/CustomerGraphQl/Model/Customer/ValidateCustomerData.php
Show resolved
Hide resolved
app/code/Magento/CustomerGraphQl/Model/Customer/ValidateCustomerData.php
Outdated
Show resolved
Hide resolved
/** | ||
* @var ValidateCustomerDataInterface[] | ||
*/ | ||
protected $validators = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the variable to private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanations, @dthampy !
done
@atwixfirster, Magento Health Index build was failing. I left a comment in the appropriate file. If you could take care of that and run all the magento tests, I think we should be good. We can then proceed with Merge. |
@magento run all tests |
ae3a9bd
to
6f918fa
Compare
@magento run all tests |
…lue in gender argument #28487
Hi @atwixfirster, thank you for your contribution! |
Description (*)
PR fixes GraphQl. updateCustomer allows to set any INT value in gender argument
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)