Fix setup upgrade command re enables caches #28491

AbdulRahmanAbouzaid · 2020-06-03T13:34:24Z

Description (*)

Fix re-enables all frontend caches after running setup:upgrade command including the disabled one BY Return them back to their old state before running setup:upgrade.

Fixed Issues (if relevant)

Fixes Running bin/magento setup:upgrade re-enables layout, block_html and full_page caches #28186

Manual testing scenarios (*)

1.Disable one of/all frontend caches [ layout, block_html and full_page] (for example: run bin/magento cache:disable layout).
2. run bin/magento setup:upgrade.
3. Run bin/magento cache:status and you can find that layout cache disabled.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-06-03T13:34:28Z

Hi @AbdulRahmanAbouzaid. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

AbdulRahmanAbouzaid · 2020-06-03T13:38:54Z

@magento run all tests

…caches

AbdulRahmanAbouzaid · 2020-06-04T12:07:09Z

@magento run all tests

…/github.com/AbdulRahmanAbouzaid/magento2 into fix_setup-upgrade_command_re-enables_caches

AbdulRahmanAbouzaid · 2020-06-04T14:12:03Z

@magento run Static Tests

AbdulRahmanAbouzaid · 2020-06-04T14:43:56Z

@magento run Integration Tests

AbdulRahmanAbouzaid · 2020-06-05T18:00:12Z

@magento run Functional Tests B2B

AbdulRahmanAbouzaid · 2020-07-09T08:50:20Z

@magento run all tests

…caches

VladimirZaets · 2020-08-19T11:03:15Z

@magento run all tests

magento-engcom-team · 2020-08-19T11:04:40Z

Hi @VladimirZaets, thank you for the review.
ENGCOM-8029 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Alfa · 2020-08-19T11:11:53Z

@VladimirZaets Could you put an appropriate label for test coverage?
Thanks!

ihor-sviziev · 2020-08-26T12:02:04Z

@engcom-Alfa I believe it requires automatic test, but not sure how to test CLI commands correctly

ihor-sviziev

✔ Approved.

Failing tests looks not related to changes form this PR.

magento-engcom-team · 2020-09-16T13:03:44Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8029 has been created to process this Pull Request

…caches

ihor-sviziev · 2020-09-17T12:19:35Z

@magento run all tests

engcom-Bravo · 2020-09-23T13:57:33Z

✔️ QA Passed

The cache status has not been changed after performing Upgrade

Manual testing scenario

Disable block_html full_page layout using the following command
bin/magento cache:disable block_html full_page layout
Run bin/magento cache:status and assert that following are set to 0
layout: 0
block_html: 0
full_page: 0
Upgrade magento instance using bin/magento setup:upgrade
Check the cache status using bin/magento cache:status

Actual Result

The previously disabled caches are still in Disabled status (0)

Current status:
                        config: 1
                        layout: 0
                    block_html: 0
                   collections: 1
                    reflection: 1
                        db_ddl: 1
               compiled_config: 1
                           eav: 1
         customer_notification: 1
            config_integration: 1
        config_integration_api: 1
                     full_page: 0
             config_webservice: 1
                     translate: 1

Before switching to PR

Current status:
                        config: 1
                        layout: 1
                    block_html: 1
                   collections: 1
                    reflection: 1
                        db_ddl: 1
               compiled_config: 1
                           eav: 1
         customer_notification: 1
            config_integration: 1
        config_integration_api: 1
                     full_page: 1
             config_webservice: 1
                     translate: 1

m2-assistant · 2020-09-24T00:58:40Z

Hi @AbdulRahmanAbouzaid, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

AbdulRahmanAbouzaid added 2 commits June 3, 2020 15:19

re-disable caches that were disabled before setup:upgrade command

e73e8e4

lowercase the un needed uppercase words

ec9462e

ghost added this to Pending Review in Pull Requests Dashboard Jun 3, 2020

ghost added the Progress: pending review label Jun 3, 2020

magento-engcom-team added Component: Setup Release Line: 2.4 Partner: Pinpoint partners-contribution Pull Request is created by Magento Partner labels Jun 3, 2020

AbdulRahmanAbouzaid added 2 commits June 4, 2020 13:02

confirm changes for only upgrade command

d8c0afd

Merge branch '2.4-develop' into fix_setup-upgrade_command_re-enables_…

3028f29

…caches

AbdulRahmanAbouzaid added 2 commits June 4, 2020 14:51

update code style

6a82be1

Merge branch 'fix_setup-upgrade_command_re-enables_caches' of https:/…

36198f2

…/github.com/AbdulRahmanAbouzaid/magento2 into fix_setup-upgrade_command_re-enables_caches

ghost added the Priority: P3 May be fixed according to the position in the backlog. label Jul 21, 2020

Merge branch '2.4-develop' into fix_setup-upgrade_command_re-enables_…

634d857

…caches

VladimirZaets approved these changes Aug 19, 2020

View reviewed changes

ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Aug 19, 2020

ghost assigned VladimirZaets Aug 19, 2020

ghost added Progress: ready for testing and removed Progress: pending review labels Aug 19, 2020

ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Sep 16, 2020

ihor-sviziev approved these changes Sep 16, 2020

View reviewed changes

ghost moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Sep 16, 2020

ghost added Progress: ready for testing and removed Progress: review labels Sep 16, 2020

ihor-sviziev added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Sep 17, 2020

Merge branch '2.4-develop' into fix_setup-upgrade_command_re-enables_…

461b644

…caches

engcom-Bravo self-assigned this Sep 23, 2020

engcom-Bravo moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 23, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Sep 23, 2020

engcom-Bravo added Progress: ready for testing QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed Progress: testing in progress labels Sep 23, 2020

engcom-Bravo moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 23, 2020

ghost added Progress: extended testing and removed Progress: ready for testing labels Sep 23, 2020

engcom-Bravo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Sep 23, 2020

ghost added Progress: accept and removed Progress: extended testing labels Sep 23, 2020

magento-engcom-team mentioned this pull request Sep 24, 2020

Running bin/magento setup:upgrade re-enables layout, block_html and full_page caches #28186

Closed

magento-engcom-team pushed a commit that referenced this pull request Sep 24, 2020

ENGCOM-8029: Fix setup upgrade command re enables caches #28491

de9fbe2

magento-engcom-team merged commit a85f600 into magento:2.4-develop Sep 24, 2020

ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 24, 2020

ihor-sviziev mentioned this pull request Dec 4, 2020

Magento CLI enforces layout, block_html and full_page caches enable #31181

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix setup upgrade command re enables caches #28491

Fix setup upgrade command re enables caches #28491

AbdulRahmanAbouzaid commented Jun 3, 2020 •

edited

m2-assistant bot commented Jun 3, 2020

AbdulRahmanAbouzaid commented Jun 3, 2020

AbdulRahmanAbouzaid commented Jun 4, 2020

AbdulRahmanAbouzaid commented Jun 4, 2020

AbdulRahmanAbouzaid commented Jun 4, 2020

AbdulRahmanAbouzaid commented Jun 5, 2020

AbdulRahmanAbouzaid commented Jul 9, 2020

VladimirZaets commented Aug 19, 2020

magento-engcom-team commented Aug 19, 2020

engcom-Alfa commented Aug 19, 2020 •

edited

ihor-sviziev commented Aug 26, 2020

ihor-sviziev left a comment

magento-engcom-team commented Sep 16, 2020

ihor-sviziev commented Sep 17, 2020

engcom-Bravo commented Sep 23, 2020

m2-assistant bot commented Sep 24, 2020

Fix setup upgrade command re enables caches #28491

Fix setup upgrade command re enables caches #28491

Conversation

AbdulRahmanAbouzaid commented Jun 3, 2020 • edited

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

m2-assistant bot commented Jun 3, 2020

AbdulRahmanAbouzaid commented Jun 3, 2020

AbdulRahmanAbouzaid commented Jun 4, 2020

AbdulRahmanAbouzaid commented Jun 4, 2020

AbdulRahmanAbouzaid commented Jun 4, 2020

AbdulRahmanAbouzaid commented Jun 5, 2020

AbdulRahmanAbouzaid commented Jul 9, 2020

VladimirZaets commented Aug 19, 2020

magento-engcom-team commented Aug 19, 2020

engcom-Alfa commented Aug 19, 2020 • edited

ihor-sviziev commented Aug 26, 2020

ihor-sviziev left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Sep 16, 2020

ihor-sviziev commented Sep 17, 2020

engcom-Bravo commented Sep 23, 2020

Manual testing scenario

Actual Result

Before switching to PR

m2-assistant bot commented Sep 24, 2020

AbdulRahmanAbouzaid commented Jun 3, 2020 •

edited

engcom-Alfa commented Aug 19, 2020 •

edited