-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magento/magento2#: GraphQl. setPaymentMethodAndPlaceOrder. Remove redundant logic. #28506
magento/magento2#: GraphQl. setPaymentMethodAndPlaceOrder. Remove redundant logic. #28506
Conversation
Hi @atwixfirster. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
Hi @atwixfirster. Could you cover this case with a test, please? |
da01e80
to
516f992
Compare
@magento run all tests |
Hi @rogyar, thank you for the review. |
@dthampy Its Ready for Testing. Has coverage. |
…-remove-redundant-logic
…-remove-redundant-logic
@magento run all tests |
…r. Remove redundant logic. #28506
Hi @atwixfirster, thank you for your contribution! |
Description (*)
PR removes a redundant logic in the
setPaymentMethodAndPlaceOrder
mutation validation conditions:because
Webonyx
coversisset($args['input']['cart_id'])
,isset($args['input']['payment_method']['code']
cases.Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Thank you!