-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFTF: Verify visibility for product's option according to current website #28545
Conversation
…fix-28291 # Conflicts: # app/code/Magento/ConfigurableProduct/Test/Unit/Block/Product/View/Type/ConfigurableTest.php
Hi @kate-kyzyma. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
@kate-kyzyma Hi, thank you! |
Hi @VladimirZaets, thank you for the review.
|
<createData entity="ConfigurableProductAddChild" stepKey="createConfigProductAddChild3"> | ||
<requiredEntity createDataKey="createConfigProduct"/> | ||
<requiredEntity createDataKey="createConfigChildProduct3"/> | ||
</createData> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</createData> | |
</createData> | |
<magentoCLI command="cron:run --group=index" stepKey="runCronIndexer"/> |
Just a minor recommendation. It worth running reindex, in this case, to avoid possible issues due to indexer settings that may lead to unstable tests.
Hi @kate-kyzyma, thank you for your contribution! |
Description (*)
Covering changes from #28365 with MFTF test.
Related Pull Requests
#28365
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)