Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF: Verify visibility for product's option according to current website #28545

Closed
wants to merge 13 commits into from
Closed

MFTF: Verify visibility for product's option according to current website #28545

wants to merge 13 commits into from

Conversation

kate-kyzyma
Copy link
Contributor

@kate-kyzyma kate-kyzyma commented Jun 5, 2020 •
edited
Loading

Description (*)

Covering changes from #28365 with MFTF test.

Related Pull Requests

#28365

Fixed Issues (if relevant)

  1. Fixes Configurable shows simple products which are no longer assigned to the website #28291 Configurable shows simple products which are no longer assigned to the website

Manual testing scenarios (*)

  1. Create additional website, store, storeview "other" in backend
  2. Create Configurable with Options, assign to both websites
  3. Set Quantity and in stock for each option in backend
  4. Check that all 3 options are there in the frontend
  5. Disable option 1 in the "main website"
  6. Check that option 1 is not shown in the frontend

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

ProkopovVitaliy and others added 13 commits May 26, 2020 09:12
@ProkopovVitaliy
set visibility for product's option according to current website
12d501a
@ProkopovVitaliy
Merge branch '2.4-develop' into fix-28291
29a9ab4
@ProkopovVitaliy
changed characters count for line
8ad107f
@ProkopovVitaliy
added unit test for allowed products count for website
557a918
@ProkopovVitaliy
refactored unit test
2e0eb14
@ProkopovVitaliy
Merge branch 'fix-28291' of github.com:ProkopovVitaliy/magento2 into …
5d06c6b 
…fix-28291

# Conflicts:
#	app/code/Magento/ConfigurableProduct/Test/Unit/Block/Product/View/Type/ConfigurableTest.php
@ProkopovVitaliy
added second website for product option
e314def
@ProkopovVitaliy
fixed condition for options
e53a499
@ProkopovVitaliy
fixed unit test taking into account the affiliation of the product to…
9a5588e 
… the website
@ProkopovVitaliy
Merge branch '2.4-develop' into fix-28291
936d388
@ProkopovVitaliy
Merge branch '2.4-develop' into fix-28291
172d0cb
@kate-kyzyma
Working on the test
3c84b85
@kate-kyzyma
Working on the test
d932f7b
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @kate-kyzyma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jun 5, 2020
@dmytro-ch dmytro-ch self-assigned this Jun 5, 2020
@kate-kyzyma kate-kyzyma mentioned this pull request Jun 5, 2020
Closed
4 tasks
@VladimirZaets
Copy link
Contributor

@magento run all tests

@VladimirZaets
Copy link
Contributor

@kate-kyzyma Hi, thank you!

@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jun 11, 2020
@ghost ghost assigned VladimirZaets Jun 11, 2020
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-7671 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 11, 2020
dmytro-ch
dmytro-ch reviewed Jun 11, 2020
View reviewed changes
...talog/Test/Mftf/Test/StorefrontConfigurableOptionsAreShownAccordingToSelectedWebsiteTest.xml
<createData entity="ConfigurableProductAddChild" stepKey="createConfigProductAddChild3">
<requiredEntity createDataKey="createConfigProduct"/>
<requiredEntity createDataKey="createConfigChildProduct3"/>
</createData>
Copy link
Contributor

@dmytro-ch dmytro-ch Jun 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</createData>
</createData>
<magentoCLI command="cron:run --group=index" stepKey="runCronIndexer"/>

Just a minor recommendation. It worth running reindex, in this case, to avoid possible issues due to indexer settings that may lead to unstable tests.

@engcom-Alfa engcom-Alfa self-assigned this Jun 12, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jun 12, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 15, 2020

Hi @kate-kyzyma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost removed this from Testing in Progress in Pull Requests Dashboard Jun 15, 2020
@kate-kyzyma kate-kyzyma deleted the fix-28291-mftf branch June 24, 2020 08:34
@kate-kyzyma kate-kyzyma restored the fix-28291-mftf branch June 24, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch left review comments

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Catalog Component: ConfigurableProduct Component: Swatches Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: testing in progress Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configurable shows simple products which are no longer assigned to the website
6 participants
@kate-kyzyma @VladimirZaets @magento-engcom-team @dmytro-ch @engcom-Alfa @ProkopovVitaliy