Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve html markup thumbnail image #28642

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Improve html markup thumbnail image #28642

merged 2 commits into from
Aug 14, 2020

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Jun 9, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Improve markup thumbnail image for easier customise
Previous only use img tag for some case impossible add style without touch directly to img tag. Add wrapper tag around img instead

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Improve html markup thumbnail image #29468: Improve html markup thumbnail image

@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jun 9, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Jun 16, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests improvement labels Jun 16, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jun 16, 2020
@ihor-sviziev ihor-sviziev added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label Jun 16, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7691 has been created to process this Pull Request

@VladimirZaets VladimirZaets added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Jun 16, 2020
@engcom-Delta engcom-Delta self-assigned this Jul 28, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 28, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked image in product grid is displayed as before
Before:
#28642Main

After:
#28642PR

@engcom-Delta engcom-Delta moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jul 28, 2020
@engcom-Charlie engcom-Charlie self-assigned this Jul 28, 2020
@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 28, 2020
@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 11, 2020
Closed
@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 11, 2020
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Aug 12, 2020
@slavvka
Copy link
Member

slavvka commented Aug 13, 2020

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Aug 14, 2020
@slavvka
ENGCOM-7691: Improve html markup thumbnail image #28642
9657870
@magento-engcom-team magento-engcom-team merged commit 57a84bd into magento:2.4-develop Aug 14, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 14, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Aug 14, 2020
@mrtuvn mrtuvn deleted the improve-column-thumbnail-image-html branch August 15, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Ui improvement Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Improve html markup thumbnail image
7 participants
@mrtuvn @ihor-sviziev @magento-engcom-team @engcom-Delta @slavvka @VladimirZaets @engcom-Charlie